Hash frozensets deterministically#8284
Open
sarathfrancis90 wants to merge 1 commit into
Open
Conversation
Sets are pickled with sorted elements so their fingerprint is stable across Python sessions, but frozensets fell back to the default reducer that keeps the iteration order. Since the string hash seed is randomized per process, a transform capturing a frozenset got a different fingerprint every run and the cache never hit. Register the same sorted reducer for frozenset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at how transforms get fingerprinted I noticed
frozensetisn't hashed deterministically, unlikeset.sethas a custom reducer (_save_set) that pickles its elements sorted, so the fingerprint is stable across runs.frozensethas no such reducer and falls back to the default one, which keeps the iteration order. Because Python randomizes the string hash seed per process, a transform that captures afrozensetof strings gets a different fingerprint every session, so the cache never hits.Repro:
I registered the same sorted reducer for
frozensetthatsetalready uses (falling back to sorting byHasher.hashfor unorderable elements). Added a test that hashes a frozenset in two subprocesses with differentPYTHONHASHSEEDand checks the hashes match, mirroring the existingsetcoverage.