Commit a932fda
committed
fix(peft_utils): raise actionable ValueError when rank_dict is empty in get_peft_kwargs
`get_peft_kwargs` is reached after callers (e.g.
`_load_lora_into_text_encoder` and the various
`load_lora_into_{unet,transformer}` flows) walk the model's
`named_modules` and probe the state_dict for
`{module}.lora_B.weight` keys. When the saved LoRA state_dict
carries an extra or missing prefix versus the target model
(e.g. `text_model.encoder.*` vs `encoder.*`), an adapter-name
infix between `lora_B` and `weight` (e.g. `.default_0.`), or a
non-diffusers serialization format that was not converted
upstream, none of the probed keys are present in the state_dict
and `rank_dict` arrives here empty.
The first statement of the function was
`r = lora_alpha = list(rank_dict.values())[0]`, which then
raised an unhelpful `IndexError: list index out of range` with
no signal about which mismatch was actually responsible (see
huggingface/peft#3238 for a real-world report against SDXL +
peft 0.19; the report was filed against peft but the failure
path is in diffusers).
Raise a `ValueError` whose message names the common causes and
shows a sample of the state_dict keys, so the next user with a
key-mismatch can diagnose their specific case from the
exception alone rather than from a 5-frame deep IndexError.
Adds focused tests for the new error path, the safe-on-None
behavior, and the unchanged fast-path.
Refs: huggingface/peft#32381 parent de5fcf6 commit a932fda
2 files changed
Lines changed: 110 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
158 | 183 | | |
159 | 184 | | |
160 | 185 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
0 commit comments