Skip to content

[tests] refactor caching tests.#13235

Open
sayakpaul wants to merge 8 commits intomainfrom
refactor-caching-tests
Open

[tests] refactor caching tests.#13235
sayakpaul wants to merge 8 commits intomainfrom
refactor-caching-tests

Conversation

@sayakpaul
Copy link
Copy Markdown
Member

@sayakpaul sayakpaul commented Mar 9, 2026

What does this PR do?

  • Refactor MagCache tests.
  • Include TaylorSeer in our model-level caching test mixin.
  • Consider removing caching-related mixins from test_pipelines_common.py.

@sayakpaul sayakpaul marked this pull request as ready for review March 10, 2026 03:27
@sayakpaul sayakpaul changed the title [wip] [tests] refactor caching tests. [tests] refactor caching tests. Mar 10, 2026
@sayakpaul sayakpaul requested a review from DN6 March 10, 2026 03:27
@sayakpaul
Copy link
Copy Markdown
Member Author

@DN6 LMK your thoughts on removing the caching-related stuff we have in test_pipelines_common.py. IMO, they're not adding much value given we have model-level caching testers for all the caching methods we support.

@github-actions github-actions Bot added tests size/L PR with diff > 200 LOC labels Apr 17, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels May 1, 2026
@sayakpaul
Copy link
Copy Markdown
Member Author

@DN6 a gentle ping.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models size/L PR with diff > 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants