Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
Author
|
@bot /style |
Contributor
|
Style bot fixed some files and pushed the changes. |
Collaborator
Author
|
@yiyixuxu Since there are some public models using modular thought it would be better to deprecate |
yiyixuxu
approved these changes
Oct 30, 2025
Collaborator
yiyixuxu
left a comment
There was a problem hiding this comment.
thanks! change looks good to me
I will run more slow tests later, but good to merge as long as you test out the public repo (krea) and make sure it works there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR
Adds support for single file loading in ComponentSpec
Renames the
repoargument topretrained_model_name_or_path. IMO this makes more sense if the same argument supports both filepath and repo_ids. Saw that there was a comment in there considering this chase, so I added it here. Alternatively, we can introduce a filename argument, but I this is cleaner.Snippet to test
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.