replace FeatureExtractor to ImageProcessor#12495
Closed
jiqing-feng wants to merge 3 commits intohuggingface:mainfrom
Closed
replace FeatureExtractor to ImageProcessor#12495jiqing-feng wants to merge 3 commits intohuggingface:mainfrom
jiqing-feng wants to merge 3 commits intohuggingface:mainfrom
Conversation
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Collaborator
|
ohhhh .......a bit tricky situation here cc @DN6 for his opinions too =, is there a better way? |
Collaborator
|
Hi @jiqing-feng I think it's better not to hardcode the check in configuration utils. We can attempt to remap the class based on the name and transformers version. Opened a PR here: #12517 |
Contributor
Author
|
OK, we can add the renamed module one by one in the map. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @sayakpaul . As transformers deprecated FeatureExtractor classes in favor of ImageProcessor classes for image preprocessing, we need to replace FeatureExtractor to ImageProcessor. To fix #12492 .
Please review this PR. Thanks!