Skip to content

[Flux.1] improve pos embed for ascend npu by computing on npu #12897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiyixuxu merged 6 commits into from
Jan 6, 2026
Merged

[Flux.1] improve pos embed for ascend npu by computing on npu #12897

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edf0a69
[Flux.1] improve pos embed for ascend npu by setting it back to npu c…
TaoZhang-Work Dec 27, 2025
23c70fd
[Flux.2] improve pos embed for ascend npu by setting it back to npu c…
TaoZhang-Work Jan 3, 2026
6efcd0a
[LongCat-Image] improve pos embed for ascend npu by setting it back t…
TaoZhang-Work Jan 3, 2026
a0f7b63
[Ovis-Image] improve pos embed for ascend npu by setting it back to n…
TaoZhang-Work Jan 3, 2026
25d2fd8
Merge branch 'main' into pos_emb_on_npu
zhangtao0408 Jan 6, 2026
bdfebd5
Remove unused import of is_torch_npu_available
TaoZhang-Work Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/diffusers/models/transformers/transformer_flux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,11 +717,7 @@ def forward(
img_ids = img_ids[0]

ids = torch.cat((txt_ids, img_ids), dim=0)
if is_torch_npu_available():
freqs_cos, freqs_sin = self.pos_embed(ids.cpu())
image_rotary_emb = (freqs_cos.npu(), freqs_sin.npu())
else:
image_rotary_emb = self.pos_embed(ids)
image_rotary_emb = self.pos_embed(ids)

if joint_attention_kwargs is not None and "ip_adapter_image_embeds" in joint_attention_kwargs:
ip_adapter_image_embeds = joint_attention_kwargs.pop("ip_adapter_image_embeds")
Expand Down