-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix BucketBatchSampler cache alignment in DreamBooth scripts #13353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sayakpaul
merged 13 commits into
huggingface:main
from
azolotenkov:fix-bucket-batch-sampler-cache-alignment
May 6, 2026
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
da85c1c
Fix bucket sampler cache alignment in DreamBooth scripts
azolotenkov 7dccd52
Shuffle precomputed DreamBooth bucket batches once
azolotenkov e31704f
Merge branch 'main' into fix-bucket-batch-sampler-cache-alignment
linoytsaban 04c6304
Scope stable bucket ordering to cached DreamBooth batches
azolotenkov 3cabf56
Format DreamBooth bucket sampler updates
azolotenkov fff6c8c
Merge branch 'main' into fix-bucket-batch-sampler-cache-alignment
azolotenkov 57f10d5
Address bucket sampler cache variable naming review
azolotenkov 8ef3fc1
Merge branch 'main' into fix-bucket-batch-sampler-cache-alignment
sayakpaul fde056d
Merge branch 'main' into fix-bucket-batch-sampler-cache-alignment
sayakpaul a476637
Merge branch 'main' into fix-bucket-batch-sampler-cache-alignment
sayakpaul 94e2c3d
Merge branch 'main' into fix-bucket-batch-sampler-cache-alignment
sayakpaul 3e253b4
Merge branch 'main' into fix-bucket-batch-sampler-cache-alignment
sayakpaul 7df7cb5
Merge branch 'main' into fix-bucket-batch-sampler-cache-alignment
sayakpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.