Add negative_prompt parameter to GLMImagePipeline#13422
Open
akshan-main wants to merge 1 commit intohuggingface:mainfrom
Open
Add negative_prompt parameter to GLMImagePipeline#13422akshan-main wants to merge 1 commit intohuggingface:mainfrom
akshan-main wants to merge 1 commit intohuggingface:mainfrom
Conversation
Collaborator
|
hi @akshan-main Thanks for the PR, however, I think the parameter was not exposed by design because this pipeline does not accept |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13421
Adds
negative_promptparameter toGLMImagePipeline.__call__()andencode_prompt(). Previously, the unconditional prompt was hardcoded to""when CFG was active, with no way for users to provide a custom negative prompt.Discussed in #13416
Changes:
negative_prompt: str | list[str] | None = Noneparameter to__call__()andencode_prompt()""whenNone(backward compatible)negative_promptis a listBefore submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@asomoza @sayakpaul @yiyixuxu