-
Notifications
You must be signed in to change notification settings - Fork 7k
Implement _dequantize for TorchAO quantizer #13538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jiqing-feng
wants to merge
6
commits into
huggingface:main
Choose a base branch
from
jiqing-feng:torchao-dequantize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bab2547
Implement _dequantize for TorchAO quantizer
jiqing-feng 9102fb8
enable dequantize for TorchAO tester mixin
jiqing-feng df36f1a
check dequantize
jiqing-feng 450d0e4
fix dequantize: clear is_quantized flag and cast dtype after dequantize
jiqing-feng 34d5c2d
fix
jiqing-feng 27d0d99
Merge branch 'main' into torchao-dequantize
jiqing-feng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -820,7 +820,12 @@ def _create_quantized_model(self, config_name, **extra_kwargs): | |
| return self.model_class.from_pretrained(self.pretrained_model_name_or_path, **kwargs) | ||
|
|
||
| def _verify_if_layer_quantized(self, name, module, config_kwargs): | ||
| from torchao.utils import TorchAOBaseTensor | ||
|
|
||
| assert isinstance(module, torch.nn.Linear), f"Layer {name} is not Linear, got {type(module)}" | ||
| assert isinstance(module.weight, TorchAOBaseTensor), ( | ||
| f"Layer {name} weight is {type(module.weight)}, expected TorchAOBaseTensor" | ||
| ) | ||
|
Comment on lines
+826
to
+828
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we also enable dequantization tests for TorchAO tester mixin?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done. |
||
|
|
||
|
|
||
| # int4wo requires CUDA or XPU ops (_convert_weight_to_int4pack) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TorchAOBaseTensordoes not expose dequantize as a public API, it is defined on child classes. I agree that it would make sense to do so in the future. If you want to be safe here it might be better to check for individual tensor subclasses that do expose it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @vkuzo! You're right that
dequantize()is defined on child classes rather than onTorchAOBaseTensoritself. I've added ahasattrguard so we safely skip any subclass that doesn't expose it. In practice all quantized tensor subclasses we encounter do implementdequantize(), but this makes it future-proof.