Fix rescale_noise_cfg zero std handling#13763
Closed
arieleli01212 wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
fixes-issue
tests
pipelines
guiders
size/M
Author
|
Going to close this one out — it's been open a while without any review, so I'll clear it from my open PRs. Happy to reopen if it's still useful to anyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rescale_noise_cfgwhen the guided noise prediction has zero varianceFixes #13425.
Tests
PYTHONPATH=src python utils/check_copies.pyruff check $(git diff --name-only) tests/others/test_rescale_noise_cfg.pyPYTHONPATH=src python -m pytest tests/others/test_rescale_noise_cfg.py -q