[core] Refactor condition embedders (and others) modules from pipelines#13781
Draft
sayakpaul wants to merge 6 commits into
Draft
[core] Refactor condition embedders (and others) modules from pipelines#13781sayakpaul wants to merge 6 commits into
pipelines#13781sayakpaul wants to merge 6 commits into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have a bunch of model-level components under
src/diffusers/pipelinesmodule. This PR factors them out of thepipelinesmodule and places them undersrc/diffusers/modelsmodule strategically.For reviewers
Main changes can be summarized as follows:
audio_tokenizer_ace_step.py) tosrc/diffusers/modelsand deprecate gracefully.autoencodersandcondition_embedders. When I wasn't sure, I simply placed them underothers. No strong opinions here.scripts/smoke_test_relocated_pretrained.pyis for transient testing until the PR is merged. Will delete it after.tests/models/test_relocated_class_loading.pywhich will check if deprecation warnings are raised and will also help to remove those deprecation paths once the cycle is over.