Fix duplicated words and a misspelling in messages and docstrings#14287
Open
Sreekant13 wants to merge 1 commit into
Open
Fix duplicated words and a misspelling in messages and docstrings#14287Sreekant13 wants to merge 1 commit into
Sreekant13 wants to merge 1 commit into
Conversation
Remove accidental repeated words in eight "must have have batch size"
error messages raised by the modular pipelines, and in two docstrings
("Dimension to to encode", "image batch to be be inpainted"). Also fix
"arbitary" to "arbitrary" in the LTX2 pipeline docstring.
Text only, no behavior change.
Contributor
|
Hi @Sreekant13, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes accidental repeated words and fixes one misspelling. Text only, no behavior change.
Eight of these are in user-facing
ValueErrormessages raised by the modular pipelines, which currently read "must have have batch size ...":modular_pipelines/anima/before_denoise.pymodular_pipelines/helios/before_denoise.pymodular_pipelines/wan/before_denoise.pymodular_pipelines/z_image/before_denoise.pymodular_pipelines/qwenimage/inputs.pymodular_pipelines/qwenimage/before_denoise.pymodular_pipelines/stable_diffusion_3/inputs.pymodular_pipelines/flux/before_denoise.pyThe remaining three are docstrings:
models/unets/unet_spatio_temporal_condition.py: "Dimension to to encode" becomes "Dimension to encode"pipelines/flux/pipeline_flux_kontext_inpaint.py: "image batch to be be inpainted" becomes "to be inpainted"pipelines/ltx2/pipeline_ltx2_condition.py: "arbitary" becomes "arbitrary"No linked issue; this is a small text-only cleanup.
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings. (The docstrings themselves are what this PR corrects.)
Self-review notes
Claude Code was used to locate the typos and prepare the diff; I reviewed and verified every change myself before submitting.
Blocking issues: none. The diff is 11 files, 11 insertions, 11 deletions, each removing one repeated word or correcting one spelling. No code paths, control flow, or public signatures are touched, and no dead code is introduced.
Findings intentionally not fixed:
pipelines/visualcloze/pipeline_visualcloze_combined.pyandpipeline_visualcloze_generation.pycontain "Images are missing in in-context examples." That looks like a repeated word but is correct English ("in" followed by "in-context"), so it is left alone.dataframe-style near misses such as "cast to to avoid" were checked for and only genuine repeats were changed.Verification: all 11 changed files byte-compile, and a repeat scan of
src/for these patterns returns no remaining matches. The branch is based on currentmain(ed58810).Who can review?
@stevhliu @sayakpaul (docs and general text), since this is a documentation and message wording change.