Fix Ascend NPU RMSNorm and fused-attention mask shapes#14288
Open
mengchengTang wants to merge 1 commit into
Open
Fix Ascend NPU RMSNorm and fused-attention mask shapes#14288mengchengTang wants to merge 1 commit into
mengchengTang wants to merge 1 commit into
Conversation
mengchengTang
force-pushed
the
fix/npu-rmsnorm-and-attn-mask-main
branch
from
July 25, 2026 06:28
d77a8f5 to
609e5b1
Compare
mengchengTang
force-pushed
the
fix/npu-rmsnorm-and-attn-mask-main
branch
from
July 25, 2026 06:43
609e5b1 to
04c4ed7
Compare
Contributor
|
Hi @mengchengTang, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two Ascend NPU incompatibilities hit when running LTX-2 with
attn_backend=_native_npu:RMSNorm with
elementwise_affine=Falseleavesweight=None.torch_npu.npu_rms_normrequires a gamma tensor, so we only use thefused kernel when
weight is not None, and otherwise fall back to theexisting PyTorch path (same as CUDA).
Fused attention mask: Ascend FA does not broadcast a singleton
query-length dim. Expand masks shaped
[B, N, 1, Skv](e.g. LTXcross-attn) to
[B, N, Sq, Skv], generalizing the existing[B, 1, 1, Skv]handling.Screenshots
Error 1 — RMSNorm /
gammais NoneError 2 — FA mask shape
[1, 32, 1, 1024]Fixes # (issue)
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.