Fix Upload PR Documentation: drop unused doc-builder install - #804
Merged
Conversation
`uv pip install --system` fails with Permission denied on the runners (the old `pip install` silently fell back to the user site), breaking every Upload PR Documentation run. Nothing in this workflow uses doc-builder, its checkout, or the current_work_dir output — the sync step runs `hf` via uvx — so remove the vestigial checkout and setup step instead of working around the permission. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mishig25
added a commit
to mishig25/trl
that referenced
this pull request
Jul 7, 2026
mishig25
added a commit
to mishig25/trl
that referenced
this pull request
Jul 7, 2026
mishig25
added a commit
to mishig25/trl
that referenced
this pull request
Jul 7, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uv-only conversion broke
upload_pr_documentation.yml:uv pip install --system ./doc-builderfails withPermission deniedon/usr/local/lib(the oldpip install .silently fell back to the user site-packages). First seen on https://github.com/huggingface/trl/actions/runs/28810540691/job/85437025416.Nothing in the workflow actually uses doc-builder, its checkout, or the
current_work_diroutput (the bucket sync runshfviauvx), so this removes the vestigial checkout + setup step entirely rather than patching the permission.🤖 Generated with Claude Code