export EvaluationModuleError and wrap _compute failures#774
Open
RavSinghChandan wants to merge 2 commits into
Open
export EvaluationModuleError and wrap _compute failures#774RavSinghChandan wants to merge 2 commits into
RavSinghChandan wants to merge 2 commits into
Conversation
Add Args/Returns/Raises/Example docstrings to filename_prefix_for_name, filename_prefix_for_split, filepattern_for_dataset_split, filename_for_dataset_split, filepath_for_dataset_split
EvaluationModuleError was defined internally but not exported, making it impossible for callers to catch evaluate-specific errors without catching broad Exception. Raw sklearn/numpy errors leaked out with no evaluate context in the traceback. - add EvaluationModuleError to module.py with a docstring example - wrap _compute call to re-raise unexpected exceptions as EvaluationModuleError - export EvaluationModuleError from evaluate/__init__.py fixes huggingface#758
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #758.
EvaluationModuleErrorexisted inmodule.pybut was never exported from the public API, so raw sklearn/numpy exceptions likeValueErrorleaked out ofEvaluationModule.compute()with no evaluate context in the traceback.Two changes:
module.py— addedEvaluationModuleErrorclass (it did not exist before) and wrapped the_computecall to catch unexpected exceptions and re-raise them asEvaluationModuleError. Already-raisedEvaluationModuleErrorinstances pass through unchanged.__init__.py— addedEvaluationModuleErrorto thefrom .module import ...line so it is importable asevaluate.EvaluationModuleError.After this change callers can write:
No logic changes to how metrics are computed. Only the exception surface is affected.