Support scalar results in combined evaluations#776
Open
zanvari wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #516.
Some evaluation modules (e.g. wer and cer) return scalar values rather than dictionaries.
CombinedEvaluations._merge_results()assumes every module returns a dictionary and attempts to call.keys()on each result, causing combined evaluation to fail.This change wraps scalar results using the corresponding evaluation module name before merging, allowing scalar-returning evaluation modules to be combined while preserving the existing behavior for dictionary-returning modules.
Tests
Added a regression test covering:
which now returns the expected combined evaluation results without raising an exception.