feat(module): add EvaluationModuleError to public API and wrap _compute exceptions#779
Open
rityagodala wants to merge 2 commits into
Open
Conversation
…te errors
- Define `EvaluationModuleError` in `module.py` (subclasses Exception)
- Wrap `self._compute(**inputs)` in `compute()` so all internal
errors (sklearn, numpy, etc.) are re-raised as `EvaluationModuleError`
with a descriptive message; already-wrapped errors are re-raised as-is
- Export `EvaluationModuleError` from `evaluate/__init__.py`
Users can now write:
except evaluate.EvaluationModuleError as e: ...
instead of catching broad Exception.
Fixes huggingface#758
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EvaluationModuleErrordid not exist in the public API, so users had no way to catch evaluate-specific errors — rawValueError/KeyErrorfrom sklearn or numpy leaked straight to the caller.Changes
src/evaluate/module.pyEvaluationModuleError(Exception)right after the logger setupself._compute(**inputs, **compute_kwargs)call incompute()so any unexpected exception is re-raised asEvaluationModuleErrorwith a descriptive message; already-typed errors are re-raised as-issrc/evaluate/__init__.pyEvaluationModuleErroralongsideEvaluationModuleBefore / After
Fixes #758