Feedback

[coyotte508]

Some feedback in random order :)

• No READMEs in packages/app and packages/mcp
• I feel like package/mcp could be renamed to package/tools (and packages/app to pacakges/mcp?)

This whole section:

https://github.com/evalstate/hf-mcp-server/blob/a1f377ae94277f376d35fa2ce2db70dab3d6d584/README.md#L24-L41

The docker:build, etc scripts don't exists at least not in the root package

This: docker build -t hf-mcp-server ., I get the following errors:

Should specify which is the default mode in the README. Also this section:

# Run with default settings (SSE transport)
npm run docker:run

Implies that the default mode is SSE but when I launched ./start.sh it it defaults to stdio:

# Default to stdio transport if not specified
TRANSPORT_TYPE="${TRANSPORT_TYPE:-stdio}"

The start command, default mcp mode is streamableHttp:

https://github.com/evalstate/hf-mcp-server/blob/a1f377ae94277f376d35fa2ce2db70dab3d6d584/packages/app/package.json#L17-L20

So basically, in the README the default mode is SSE, in the docker file it's Stdio, and in the pnpm command it's StreamableHttp.

• no mention of pnpm in the readme, while it's the package manager used

• pnpm install && pnpm -r dev should be enough to launch, when I do that and go on http://localhost:3000 I get a 404

• I need to manually enable adminstration tools here: https://evalstate-hf-mcp-server.hf.space/ btw the name "administration tool" makes me think it's an admin stuff, it's just a user managing their repos

  • I don't think there's a need to split search & management
  • we can add whoami endpoint so the user can find own repos easily, it's a mix between search & management
  • management should be enabled by default
  • should be configurable by command line args or by an env file / etc (currently no persistence and not everything enabled by default)
  • maybe everything should just always be enabled to simplify stuff for now

• an example config to use the MCP in cursor or vscode (with custom HF token specified in the cursor/VSCode config) would be nice, and a screenshot of a chat conversation using it too

• no need to pnpm --filter @hf-mcp/mcp, can just do pnpm --filter mcp (same with app)

• can use -r instead of --recursive,

• top level commands are maybe not needed, eg you can just say pnpm -r build in the README.

• The start top-level command builds (not sure we should do that as part of start) and then uses cd instead of just pnpm --filter app start

[evalstate]

Some feedback in random order :)

• No READMEs in packages/app and packages/mcp
• I feel like package/mcp could be renamed to package/tools (and packages/app to pacakges/mcp?)

Will fix (#4)

This whole section:

hf-mcp-server/README.md

Lines 24 to 41 in a1f377a

Docker Usage

Using NPM Scripts

We provide several npm scripts to simplify Docker operations:

# Build the Docker image 
npm run docker:build 
 
# Run with default settings (SSE transport) 
npm run docker:run 
 
# Run with specific transport types 
npm run docker:run:sse 
npm run docker:run:stdio 
npm run docker:run:streamableHttp 

The docker:build, etc scripts don't exists at least not in the root package

This: docker build -t hf-mcp-server ., I get the following errors:

Should already be fixed in the last commit :)

Should specify which is the default mode in the README. Also this section:

Run with default settings (SSE transport)

npm run docker:run
Implies that the default mode is SSE but when I launched ./start.sh it it defaults to stdio:

Default to stdio transport if not specified

TRANSPORT_TYPE="${TRANSPORT_TYPE:-stdio}"
The start command, default mcp mode is streamableHttp:

hf-mcp-server/packages/app/package.json

Lines 17 to 20 in a1f377a

"start": "cross-env NODE_ENV=production node dist/server/streamableHttp.js",
"start:json": "cross-env NODE_ENV=production node dist/server/streamableHttp.js --json",
"start:stdio": "cross-env NODE_ENV=production node dist/server/stdio.js",
"start:sse": "cross-env NODE_ENV=production node dist/server/sse.js",
So basically, in the README the default mode is SSE, in the docker file it's Stdio, and in the pnpm command it's StreamableHttp.

Will do with #4

• no mention of pnpm in the readme, while it's the package manager used
• pnpm install && pnpm -r dev should be enough to launch, when I do that and go on http://localhost:3000 I get a 404
• I need to manually enable adminstration tools here: https://evalstate-hf-mcp-server.hf.space/ btw the name "administration tool" makes me think it's an admin stuff, it's just a user managing their repos

Will remove feature as I haven't ported the tools across, and now you're here will use some branch discipline 😂. #5

• I don't think there's a need to split search & management
• we can add whoami endpoint so the user can find own repos easily, it's a mix between search & management
• management should be enabled by default
• should be configurable by command line args or by an env file / etc (currently no persistence and not everything enabled by default)
• maybe everything should just always be enabled to simplify stuff for now

As on Slack, will default to all-on but get real status from API endpoint.

• an example config to use the MCP in cursor or vscode (with custom HF token specified in the cursor/VSCode config) would be nice, and a screenshot of a chat conversation using it too
• no need to pnpm --filter @hf-mcp/mcp, can just do pnpm --filter mcp (same with app)
• can use -r instead of --recursive,
• top level commands are maybe not needed, eg you can just say pnpm -r build in the README.
• The start top-level command builds (not sure we should do that as part of start) and then uses cd instead of just pnpm --filter app start

Will tidy up the builds (may come to you help).