Skip to content

Create spaces-custom-domain.md - #1746

Merged
pcuenca merged 4 commits into
mainfrom
spaces-custom-domain
Aug 8, 2025
Merged

Create spaces-custom-domain.md#1746
pcuenca merged 4 commits into
mainfrom
spaces-custom-domain

Conversation

@Michellehbn

Copy link
Copy Markdown
Member

No description provided.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Michellehbn
Michellehbn marked this pull request as ready for review May 27, 2025 13:57

@burtenshaw burtenshaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/hub/spaces-custom-domain.md Outdated
Comment thread docs/hub/spaces-custom-domain.md Outdated
Comment thread docs/hub/spaces-custom-domain.md Outdated
Comment thread docs/hub/spaces-custom-domain.md Outdated
@abidlabs

abidlabs commented Aug 7, 2025

Copy link
Copy Markdown
Member

Can we merge this in? I was looking for information about custom domains on Spaces and couldn't find it.

Also: as it turns out, if you add a custom domain to your Space, the SPACE_HOST env variable becomes a comma separated list that includes both the original hf.space domain and the custom domain. Would be good to note that either in this doc or in https://github.com/huggingface/hub-docs/edit/main/docs/hub/spaces-overview.md

Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: burtenshaw <ben.burtenshaw@gmail.com>
@pcuenca

pcuenca commented Aug 8, 2025

Copy link
Copy Markdown
Member

Can we merge this in? I was looking for information about custom domains on Spaces and couldn't find it.

Good point @abidlabs! I think @Michellehbn is OOO, so I'll take the liberty to accept all suggestions and merge. My apologies Michelle! 🙏

Regarding your additional suggestion, in my opinion we can iterate in a new PR.

@pcuenca
pcuenca merged commit 97f75c0 into main Aug 8, 2025
2 checks passed
@pcuenca
pcuenca deleted the spaces-custom-domain branch August 8, 2025 10:32
@julien-c

Copy link
Copy Markdown
Member

needs to be added to the TOC otherwise users can't find it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants