Skip to content

docs(xet): update broken xet-core links after repo re-org#2477

Merged
assafvayner merged 2 commits into
mainfrom
fix-xet-doc-links
May 15, 2026
Merged

docs(xet): update broken xet-core links after repo re-org#2477
assafvayner merged 2 commits into
mainfrom
fix-xet-doc-links

Conversation

@assafvayner

@assafvayner assafvayner commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary

The xet-core repository was reorganized: the per-crate top-level directories (cas_types, cas_client, mdb_shard, merklehash, deduplication, data, hf_xet_thin_wasm, cas_object) were merged into a smaller set of larger crates (xet_client, xet_core_structures, xet_data, wasm/hf_xet_thin_wasm). All the cross-repo links from docs/xet/ to those old paths now 404.

This PR:

  1. Updates every broken link in docs/xet/ to point at the new paths.
  2. Pins the four line-anchored "reference implementation" links in hashing.md to xet-core commit c3c726b so the line numbers don't drift as upstream code changes. Directory and whole-file links stay on main since they don't suffer from line drift.

Path mapping applied:

Old New
cas_types/ xet_client/src/cas_types/
cas_client/ xet_client/src/cas_client/
mdb_shard/ xet_core_structures/src/metadata_shard/
deduplication/ xet_data/src/deduplication/
merklehash/ xet_core_structures/src/merklehash/
data/ xet_data/
cas_object/src/byte_grouping/ xet_core_structures/src/xorb_object/byte_grouping/
hf_xet_thin_wasm/ wasm/hf_xet_thin_wasm/

Line ranges in hashing.md were re-anchored against the pinned commit so each "reference implementation" link still points at the matching code:

  • data_hash.rs compute_data_hash: L308-L311L310-L313
  • aggregated_hashes.rs internal-node merge (merged_hash_of_sequence): L103-L109L123-L136
  • aggregated_hashes.rs file-hash entry point (file_hash): L123-L125L191-L195
  • chunk_verification.rs: L4-L16 is still correct after the move

Files touched: docs/xet/index.md, docs/xet/hashing.md, docs/xet/xorb.md.

Test plan

  • Click through each updated link in the rendered docs/xet pages and confirm they resolve.
  • Spot-check the line-anchored links in hashing.md highlight the intended functions (compute_data_hash, merged_hash_of_sequence, file_hash, range_hash_from_chunks).

The xet-core repository was reorganized: the per-crate top-level
directories (cas_types, cas_client, mdb_shard, merklehash,
deduplication, data, hf_xet_thin_wasm, cas_object) were merged into a
smaller set of larger crates (xet_client, xet_core_structures,
xet_data, wasm/hf_xet_thin_wasm). Update all references in docs/xet/
to point at the new paths, and shift the line ranges in hashing.md to
the corresponding code in the new locations.
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@assafvayner
assafvayner requested a review from rajatarya May 14, 2026 21:38
@assafvayner
assafvayner marked this pull request as ready for review May 14, 2026 21:38

@pcuenca pcuenca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the ones that include line ranges should be permalinks?

The four "reference implementation" links in hashing.md include line
anchors (#L...). Pin them to xet-core commit c3c726b so the line
numbers don't drift as upstream code changes.
@assafvayner
assafvayner merged commit 547e06e into main May 15, 2026
3 checks passed
@assafvayner
assafvayner deleted the fix-xet-doc-links branch May 15, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants