Skip to content

quickfix: removing cells that hardcoded role in notebook#2585

Merged
dwarez merged 1 commit into
mainfrom
quickfix/deploy-embedding-models
Jun 23, 2026
Merged

quickfix: removing cells that hardcoded role in notebook#2585
dwarez merged 1 commit into
mainfrom
quickfix/deploy-embedding-models

Conversation

@dwarez

@dwarez dwarez commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Documentation-only notebook edit with no runtime or security logic changes in application code.

Overview
Removes a code cell in the SageMaker embedding deployment notebook that hardcoded role to a specific AWS account IAM ARN (754289655784).

Readers now rely on the existing setup cell that resolves the role via get_execution_role() (or the sagemaker_execution_role fallback), so the notebook works in their own account without copying a foreign role ARN.

Reviewed by Cursor Bugbot for commit 64366ce. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: DWarez <dario.salvati@huggingface.co>
@dwarez
dwarez requested a review from ehcalabres June 23, 2026 13:50
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@dwarez
dwarez merged commit c864d94 into main Jun 23, 2026
3 checks passed
@dwarez
dwarez deleted the quickfix/deploy-embedding-models branch June 23, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants