quickfix: removing cells that hardcoded role in notebook#2585
Merged
Conversation
Signed-off-by: DWarez <dario.salvati@huggingface.co>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ehcalabres
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Documentation-only notebook edit with no runtime or security logic changes in application code.
Overview
Removes a code cell in the SageMaker embedding deployment notebook that hardcoded
roleto a specific AWS account IAM ARN (754289655784).Readers now rely on the existing setup cell that resolves the role via
get_execution_role()(or thesagemaker_execution_rolefallback), so the notebook works in their own account without copying a foreign role ARN.Reviewed by Cursor Bugbot for commit 64366ce. Bugbot is set up for automated code reviews on this repo. Configure here.