chore(eslint): require block statements via curly: all

julien-c · julien-c · commit 6ce783f2f335 · 2026-05-22T15:38:43.000+02:00
Adds the `curly: ["error", "all"]` ESLint rule so single-line bodies
on `if`/`else`/`for`/`while` must be wrapped in `{ }`. Runs
`eslint --fix` + `oxfmt` over the affected files (8 packages, 25
sources).
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -24,6 +24,7 @@ module.exports = {
 		"@typescript-eslint/no-empty-interfaces": "off",
 		// For doc purposes, prefer interfaces
 		"@typescript-eslint/consistent-type-definitions": ["error", "interface"],
+		curly: ["error", "all"],
 	},
 	overrides: [
 		{
diff --git a/packages/agents/src/tools/imageToText.ts b/packages/agents/src/tools/imageToText.ts
@@ -12,7 +12,9 @@ export const imageToTextTool: Tool = {
 	],
 	call: async (input, inference) => {
 		const data = await input;
-		if (typeof data === "string") throw "Input must be a blob.";
+		if (typeof data === "string") {
+			throw "Input must be a blob.";
+		}
 
 		return (
 			// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
diff --git a/packages/agents/src/tools/speechToText.ts b/packages/agents/src/tools/speechToText.ts
@@ -12,7 +12,9 @@ export const speechToTextTool: Tool = {
 	],
 	call: async (input, inference) => {
 		const data = await input;
-		if (typeof data === "string") throw "Input must be a blob.";
+		if (typeof data === "string") {
+			throw "Input must be a blob.";
+		}
 
 		return (
 			await inference.automaticSpeechRecognition({
diff --git a/packages/agents/src/tools/textToImage.ts b/packages/agents/src/tools/textToImage.ts
@@ -17,7 +17,9 @@ export const textToImageTool: Tool = {
 	],
 	call: async (input, inference) => {
 		const data = await input;
-		if (typeof data !== "string") throw "Input must be a string.";
+		if (typeof data !== "string") {
+			throw "Input must be a string.";
+		}
 
 		return await inference.textToImage({
 			inputs: data,
diff --git a/packages/agents/src/tools/textToSpeech.ts b/packages/agents/src/tools/textToSpeech.ts
@@ -17,7 +17,9 @@ export const textToSpeechTool: Tool = {
 	],
 	call: async (input, inference) => {
 		const data = await input;
-		if (typeof data !== "string") throw "Input must be a string.";
+		if (typeof data !== "string") {
+			throw "Input must be a string.";
+		}
 
 		return inference.textToSpeech({
 			inputs: data,
diff --git a/packages/gguf/scripts/generate-llm.ts b/packages/gguf/scripts/generate-llm.ts
@@ -188,7 +188,9 @@ async function main() {
 		const tensorMatched = line.match(/LLM_TENSOR_[A-Z0-9_]+[,\s]+"(?<name>.+?)"/);
 		if (tensorMatched?.groups) {
 			const arch = archList.find((a) => a.cppConst === currCppConst);
-			if (arch) arch.tensorNames.push(tensorMatched.groups.name);
+			if (arch) {
+				arch.tensorNames.push(tensorMatched.groups.name);
+			}
 		}
 	}
 
diff --git a/packages/hub/cli.ts b/packages/hub/cli.ts
@@ -38,7 +38,9 @@ class UploadProgressManager {
 	}
 
 	async initialize(): Promise<void> {
-		if (this.isQuiet) return;
+		if (this.isQuiet) {
+			return;
+		}
 
 		try {
 			const cliProgress = await import("cli-progress");
@@ -60,7 +62,9 @@ class UploadProgressManager {
 	}
 
 	handleEvent(event: CommitProgressEvent): void {
-		if (this.isQuiet) return;
+		if (this.isQuiet) {
+			return;
+		}
 
 		if (event.event === "phase") {
 			this.logPhase(event.phase);
@@ -70,7 +74,9 @@ class UploadProgressManager {
 	}
 
 	private logPhase(phase: string): void {
-		if (this.isQuiet) return;
+		if (this.isQuiet) {
+			return;
+		}
 
 		const phaseMessages = {
 			preuploading: "📋 Preparing files for upload...",
@@ -82,7 +88,9 @@ class UploadProgressManager {
 	}
 
 	private updateFileProgress(path: string, progress: number, state: string): void {
-		if (this.isQuiet) return;
+		if (this.isQuiet) {
+			return;
+		}
 
 		if (this.cliProgressAvailable && this.multibar) {
 			// Use progress bars
@@ -124,7 +132,9 @@ class UploadProgressManager {
 	}
 
 	private truncateFilename(filename: string, maxLength: number): string {
-		if (filename.length <= maxLength) return filename;
+		if (filename.length <= maxLength) {
+			return filename;
+		}
 		return "..." + filename.slice(-(maxLength - 3));
 	}
 
diff --git a/packages/hub/src/lib/cache-management.ts b/packages/hub/src/lib/cache-management.ts
@@ -70,7 +70,9 @@ export interface HFCacheInfo {
 }
 
 export async function scanCacheDir(cacheDir: string | undefined = undefined): Promise<HFCacheInfo> {
-	if (!cacheDir) cacheDir = getHFHubCachePath();
+	if (!cacheDir) {
+		cacheDir = getHFHubCachePath();
+	}
 
 	const s = await stat(cacheDir);
 	if (!s.isDirectory()) {
@@ -85,7 +87,9 @@ export async function scanCacheDir(cacheDir: string | undefined = undefined): Pr
 	const directories = await readdir(cacheDir);
 	for (const repo of directories) {
 		// skip .locks folder
-		if (repo === ".locks") continue;
+		if (repo === ".locks") {
+			continue;
+		}
 
 		// get the absolute path of the repo
 		const absolute = join(cacheDir, repo);
@@ -144,7 +148,9 @@ export async function scanCachedRepo(repoPath: string): Promise<CachedRepoInfo>
 
 	const snapshotDirs = await readdir(snapshotsPath);
 	for (const dir of snapshotDirs) {
-		if (FILES_TO_IGNORE.includes(dir)) continue; // Ignore unwanted files
+		if (FILES_TO_IGNORE.includes(dir)) {
+			continue;
+		} // Ignore unwanted files
 
 		const revisionPath = join(snapshotsPath, dir);
 		const revisionStat = await stat(revisionPath);
@@ -205,7 +211,9 @@ export async function scanRefsDir(refsPath: string, refsByHash: Map<string, stri
 	const refFiles = await readdir(refsPath, { withFileTypes: true });
 	for (const refFile of refFiles) {
 		const refFilePath = join(refsPath, refFile.name);
-		if (refFile.isDirectory()) continue; // Skip directories
+		if (refFile.isDirectory()) {
+			continue;
+		} // Skip directories
 
 		const commitHash = await readFile(refFilePath, "utf-8");
 		const refName = refFile.name;
@@ -223,7 +231,9 @@ export async function scanSnapshotDir(
 ): Promise<void> {
 	const files = await readdir(revisionPath, { withFileTypes: true });
 	for (const file of files) {
-		if (file.isDirectory()) continue; // Skip directories
+		if (file.isDirectory()) {
+			continue;
+		} // Skip directories
 
 		const filePath = join(revisionPath, file.name);
 		const blobPath = await realpath(filePath);
diff --git a/packages/hub/src/lib/download-file-to-cache-dir.ts b/packages/hub/src/lib/download-file-to-cache-dir.ts
@@ -79,7 +79,9 @@ export async function downloadFileToCacheDir(
 	if (revision && REGEX_COMMIT_HASH.test(revision)) {
 		commitHash = revision;
 		const pointerPath = getFilePointer(storageFolder, revision, params.path);
-		if (await exists(pointerPath, true)) return pointerPath;
+		if (await exists(pointerPath, true)) {
+			return pointerPath;
+		}
 	}
 
 	const pathsInformation: PathInfo[] = await pathsInfo({
@@ -88,7 +90,9 @@ export async function downloadFileToCacheDir(
 		revision,
 		expand: true,
 	});
-	if (!pathsInformation || pathsInformation.length !== 1) throw new Error(`cannot get path info for ${params.path}`);
+	if (!pathsInformation || pathsInformation.length !== 1) {
+		throw new Error(`cannot get path info for ${params.path}`);
+	}
 
 	const info = pathsInformation[0];
 	let etag: string;
diff --git a/packages/hub/src/lib/jobs/stream-job-events.ts b/packages/hub/src/lib/jobs/stream-job-events.ts
@@ -51,7 +51,9 @@ export async function* streamJobEvents(
 	try {
 		while (true) {
 			const { done, value } = await reader.read();
-			if (done) break;
+			if (done) {
+				break;
+			}
 
 			buffer += decoder.decode(value, { stream: true });
 			const lines = buffer.split("\n");
diff --git a/packages/hub/src/lib/jobs/stream-job-logs.ts b/packages/hub/src/lib/jobs/stream-job-logs.ts
@@ -51,7 +51,9 @@ export async function* streamJobLogs(
 	try {
 		while (true) {
 			const { done, value } = await reader.read();
-			if (done) break;
+			if (done) {
+				break;
+			}
 
 			buffer += decoder.decode(value, { stream: true });
 			const lines = buffer.split("\n");
diff --git a/packages/hub/src/lib/jobs/stream-job-metrics.ts b/packages/hub/src/lib/jobs/stream-job-metrics.ts
@@ -51,7 +51,9 @@ export async function* streamJobMetrics(
 	try {
 		while (true) {
 			const { done, value } = await reader.read();
-			if (done) break;
+			if (done) {
+				break;
+			}
 
 			buffer += decoder.decode(value, { stream: true });
 			const lines = buffer.split("\n");
diff --git a/packages/hub/src/lib/parse-safetensors-metadata.ts b/packages/hub/src/lib/parse-safetensors-metadata.ts
@@ -240,8 +240,12 @@ async function fetchAllHeaders(
 }
 
 function parseTotalParameters(value: string | number | undefined): number | undefined {
-	if (!value) return undefined;
-	if (typeof value === "number") return value;
+	if (!value) {
+		return undefined;
+	}
+	if (typeof value === "number") {
+		return value;
+	}
 	return parseInt(value);
 }
 
@@ -388,16 +392,22 @@ export function globMatch(pattern: string, str: string): boolean {
 		return pattern === str;
 	}
 
-	if (!str.startsWith(parts[0])) return false;
+	if (!str.startsWith(parts[0])) {
+		return false;
+	}
 	let pos = parts[0].length;
 
 	const lastPart = parts[parts.length - 1];
-	if (!str.endsWith(lastPart)) return false;
+	if (!str.endsWith(lastPart)) {
+		return false;
+	}
 	const end = str.length - lastPart.length;
 
 	for (let i = 1; i < parts.length - 1; i++) {
 		const idx = str.indexOf(parts[i], pos);
-		if (idx === -1 || idx + parts[i].length > end) return false;
+		if (idx === -1 || idx + parts[i].length > end) {
+			return false;
+		}
 		pos = idx + parts[i].length;
 	}
 
@@ -412,9 +422,13 @@ export function globMatch(pattern: string, str: string): boolean {
  * pattern contains a `*` we fall back to proper glob matching for flexibility.
  */
 export function isQuantizedTensor(tensorName: string, quantConfig?: QuantizationConfig): boolean {
-	if (!quantConfig) return false;
+	if (!quantConfig) {
+		return false;
+	}
 	const patterns = quantConfig.modules_to_not_convert;
-	if (!patterns?.length) return true;
+	if (!patterns?.length) {
+		return true;
+	}
 	return !patterns.some((pattern) =>
 		pattern.includes("*") ? globMatch(pattern, tensorName) : tensorName.includes(pattern),
 	);
@@ -520,10 +534,16 @@ function getTensorSuffix(tensorName: string): string {
 }
 
 function shouldSkipTensor(tensorName: string, quantConfig?: QuantizationConfig): boolean {
-	if (!quantConfig) return false;
+	if (!quantConfig) {
+		return false;
+	}
 	const quantMethod = quantConfig.quant_method?.toLowerCase();
-	if (quantMethod !== "gptq" && quantMethod !== "awq") return false;
-	if (!isQuantizedTensor(tensorName, quantConfig)) return false;
+	if (quantMethod !== "gptq" && quantMethod !== "awq") {
+		return false;
+	}
+	if (!isQuantizedTensor(tensorName, quantConfig)) {
+		return false;
+	}
 	const suffix = getTensorSuffix(tensorName);
 	return suffix !== GPTQ_QWEIGHT_SUFFIX && GPTQ_AWQ_AUXILIARY_SUFFIXES.includes(suffix);
 }
diff --git a/packages/hub/src/lib/paths-info.ts b/packages/hub/src/lib/paths-info.ts
@@ -118,7 +118,9 @@ export async function pathsInfo(
 	}
 
 	const json: unknown = await resp.json();
-	if (!Array.isArray(json)) throw new Error("malformed response: expected array");
+	if (!Array.isArray(json)) {
+		throw new Error("malformed response: expected array");
+	}
 
 	return json.map((item: PathInfo) => ({
 		path: item.path,
diff --git a/packages/hub/src/utils/createXorbs.ts b/packages/hub/src/utils/createXorbs.ts
@@ -61,7 +61,9 @@ function finalizeChunker(
 	chunker: ReturnType<typeof createChunker>,
 ): { hash: string; length: number; dedup: boolean }[] {
 	const last = finalize(chunker);
-	if (!last) return [];
+	if (!last) {
+		return [];
+	}
 	return [{ hash: hashToHex(last.hash), length: last.length, dedup: false }];
 }
 
diff --git a/packages/inference/scripts/export-templates.ts b/packages/inference/scripts/export-templates.ts
@@ -15,22 +15,28 @@ function exportTemplatesAsCode(): string {
 	const languages = readdirSync(TEMPLATES_DIR);
 	for (const language of languages) {
 		const languagePath = path.join(TEMPLATES_DIR, language);
-		if (!readdirSync(languagePath).length) continue;
+		if (!readdirSync(languagePath).length) {
+			continue;
+		}
 
 		templates[language] = {};
 
 		// Read all client directories
 		const clients = readdirSync(languagePath);
 		for (const client of clients) {
 			const clientPath = path.join(languagePath, client);
-			if (!readdirSync(clientPath).length) continue;
+			if (!readdirSync(clientPath).length) {
+				continue;
+			}
 
 			templates[language][client] = {};
 
 			// Read all template files
 			const files = readdirSync(clientPath);
 			for (const file of files) {
-				if (!file.endsWith(".jinja")) continue;
+				if (!file.endsWith(".jinja")) {
+					continue;
+				}
 
 				const templatePath = path.join(clientPath, file);
 				const templateContent = readFileSync(templatePath, "utf8");
diff --git a/packages/inference/src/providers/hf-inference.ts b/packages/inference/src/providers/hf-inference.ts
@@ -356,7 +356,9 @@ export class HFInferenceDocumentQuestionAnsweringTask
 export class HFInferenceFeatureExtractionTask extends HFInferenceTask implements FeatureExtractionTaskHelper {
 	override async getResponse(response: FeatureExtractionOutput): Promise<FeatureExtractionOutput> {
 		const isNumArrayRec = (arr: unknown[], maxDepth: number, curDepth = 0): boolean => {
-			if (curDepth > maxDepth) return false;
+			if (curDepth > maxDepth) {
+				return false;
+			}
 			if (arr.every((x) => Array.isArray(x))) {
 				return arr.every((x) => isNumArrayRec(x as unknown[], maxDepth, curDepth + 1));
 			} else {
diff --git a/packages/inference/src/providers/replicate.ts b/packages/inference/src/providers/replicate.ts
@@ -236,8 +236,12 @@ export class ReplicateAutomaticSpeechRecognitionTask
 		_outputType?: undefined,
 		signal?: AbortSignal,
 	): Promise<AutomaticSpeechRecognitionOutput> {
-		if (typeof response?.output === "string") return { text: response.output };
-		if (Array.isArray(response?.output) && typeof response.output[0] === "string") return { text: response.output[0] };
+		if (typeof response?.output === "string") {
+			return { text: response.output };
+		}
+		if (Array.isArray(response?.output) && typeof response.output[0] === "string") {
+			return { text: response.output[0] };
+		}
 
 		const out = response?.output as
 			| undefined
@@ -247,8 +251,12 @@ export class ReplicateAutomaticSpeechRecognitionTask
 					txt_file?: string;
 			  };
 		if (out && typeof out === "object") {
-			if (typeof out.transcription === "string") return { text: out.transcription };
-			if (typeof out.translation === "string") return { text: out.translation };
+			if (typeof out.transcription === "string") {
+				return { text: out.transcription };
+			}
+			if (typeof out.translation === "string") {
+				return { text: out.translation };
+			}
 			if (typeof out.txt_file === "string") {
 				const r = await fetch(out.txt_file, { signal });
 				return { text: await r.text() };
diff --git a/packages/inference/src/providers/together.ts b/packages/inference/src/providers/together.ts
diff --git a/packages/jinja/src/format.ts b/packages/jinja/src/format.ts
diff --git a/packages/jinja/src/lexer.ts b/packages/jinja/src/lexer.ts
diff --git a/packages/jinja/src/runtime.ts b/packages/jinja/src/runtime.ts
diff --git a/packages/jinja/src/utils.ts b/packages/jinja/src/utils.ts
diff --git a/packages/ollama-utils/scripts/generate-automap.ts b/packages/ollama-utils/scripts/generate-automap.ts
diff --git a/packages/space-header/src/index.ts b/packages/space-header/src/index.ts
diff --git a/packages/tasks/src/model-libraries-snippets.ts b/packages/tasks/src/model-libraries-snippets.ts

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ module.exports = {`
`24`	`24`	`"@typescript-eslint/no-empty-interfaces": "off",`
`25`	`25`	`// For doc purposes, prefer interfaces`
`26`	`26`	`"@typescript-eslint/consistent-type-definitions": ["error", "interface"],`
	`27`	`+ curly: ["error", "all"],`
`27`	`28`	`},`
`28`	`29`	`overrides: [`
`29`	`30`	`{`
Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,9 @@ async function main() {`
`188`	`188`	`const tensorMatched = line.match(/LLM_TENSOR_[A-Z0-9_]+[,\s]+"(?<name>.+?)"/);`
`189`	`189`	`if (tensorMatched?.groups) {`
`190`	`190`	`const arch = archList.find((a) => a.cppConst === currCppConst);`
`191`		`- if (arch) arch.tensorNames.push(tensorMatched.groups.name);`
	`191`	`+ if (arch) {`
	`192`	`+ arch.tensorNames.push(tensorMatched.groups.name);`
	`193`	`+ }`
`192`	`194`	`}`
`193`	`195`	`}`
`194`	`196`