Skip to content

Accept null score in hf-inference image-segmentation response #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Accept null score in hf-inference image-segmentation response #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/inference/src/providers/hf-inference.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,10 +393,15 @@ export class HFInferenceImageSegmentationTask extends HFInferenceTask implements
(x) =>
typeof x.label === "string" &&
typeof x.mask === "string" &&
(x.score === undefined || typeof x.score === "number"),
(x.score === undefined || x.score === null || typeof x.score === "number"),
Comment thread
cursor[bot] marked this conversation as resolved.
)
) {
return response;
// Coerce `null` scores (returned by some HF models, e.g. face-parsing)
// to `undefined` so the result matches the declared
// `ImageSegmentationOutputElement` type (`score?: number`). Without
// this, downstream consumers using `if (segment.score !== undefined)`
// would treat `null` as a valid number and crash on numeric ops.
return response.map((x) => (x.score === null ? { ...x, score: undefined } : x));
}
throw new InferenceClientProviderOutputError(
"Received malformed response from HF-Inference image-segmentation API: expected Array<{label: string, mask: string, score: number}>",
Expand Down