Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

Commit 2d4ae3b

Browse files
committed
Rename upstreamVariant to bundleBuild
1 parent c140f36 commit 2d4ae3b

6 files changed

Lines changed: 22 additions & 22 deletions

File tree

examples/relu-specific-torch/flake.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"x86_64-linux"
2323
"aarch64-linux"
2424
];
25-
upstreamVariant = true;
25+
bundleBuild = true;
2626
}
2727
];
2828
};

lib/build-sets.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ let
5959
torchVersion,
6060
cxx11Abi,
6161
system,
62-
upstreamVariant ? false,
62+
bundleBuild ? false,
6363
}:
6464
let
6565
pkgs =
@@ -80,7 +80,7 @@ let
8080
buildConfig
8181
pkgs
8282
torch
83-
upstreamVariant
83+
bundleBuild
8484
;
8585
};
8686

lib/build-variants.nix

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ rec {
1919
else
2020
throw "Could not find compute framework: no CUDA or ROCm version specified and Metal is not enabled";
2121

22-
# Upstream build variants.
22+
# Build variants included in bundle builds.
2323
buildVariants =
2424
let
2525
inherit (import ./version-utils.nix { inherit lib; }) abiString flattenVersion;
@@ -39,7 +39,7 @@ rec {
3939
"torch${flattenVersion version.torchVersion}-${computeString version}-${version.system}"
4040
else
4141
"torch${flattenVersion version.torchVersion}-${abiString version.cxx11Abi}-${computeString version}-${version.system}";
42-
upstreamVersions = lib.filter (version: version.upstreamVariant or false);
42+
bundleBuildVersions = lib.filter (version: version.bundleBuild or false);
4343
in
4444
lib.foldl' (
4545
acc: version:
@@ -51,5 +51,5 @@ rec {
5151
pathVersions = lib.attrByPath path [ ] acc ++ [ (buildName version) ];
5252
in
5353
lib.recursiveUpdate acc (lib.setAttrByPath path pathVersions)
54-
) { } (flattenSystems (upstreamVersions torchVersions));
54+
) { } (flattenSystems (bundleBuildVersions torchVersions));
5555
}

lib/build-version.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
buildConfig,
33
pkgs,
44
torch,
5-
upstreamVariant,
5+
bundleBuild,
66
}:
77
let
88
inherit (pkgs) lib;

lib/build.nix

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ rec {
9090
buildConfig,
9191
pkgs,
9292
torch,
93-
upstreamVariant,
93+
bundleBuild,
9494
}:
9595
{
9696
path,
@@ -199,10 +199,10 @@ rec {
199199
let
200200
# We just need to get any nixpkgs for use by the path join.
201201
pkgs = (builtins.head buildSets).pkgs;
202-
upstreamBuildSets = builtins.filter (buildSet: buildSet.upstreamVariant) buildSets;
202+
bundleBuildSets = builtins.filter (buildSet: buildSet.bundleBuild) buildSets;
203203
extensions = buildDistTorchExtensions {
204204
inherit path rev doGetKernelCheck;
205-
buildSets = upstreamBuildSets;
205+
buildSets = bundleBuildSets;
206206
};
207207
buildConfig = readBuildConfig path;
208208
namePaths =

versions.nix

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
cudaVersion = "11.8";
55
cxx11Abi = true;
66
systems = [ "x86_64-linux" ];
7-
upstreamVariant = true;
7+
bundleBuild = true;
88
}
99
{
1010
torchVersion = "2.7";
@@ -13,7 +13,7 @@
1313
systems = [
1414
"x86_64-linux"
1515
];
16-
upstreamVariant = true;
16+
bundleBuild = true;
1717
}
1818
{
1919
torchVersion = "2.7";
@@ -23,29 +23,29 @@
2323
"x86_64-linux"
2424
"aarch64-linux"
2525
];
26-
upstreamVariant = true;
26+
bundleBuild = true;
2727
}
2828
{
2929
torchVersion = "2.7";
3030
rocmVersion = "6.3.4";
3131
cxx11Abi = true;
3232
systems = [ "x86_64-linux" ];
33-
upstreamVariant = true;
33+
bundleBuild = true;
3434
}
3535
{
3636
torchVersion = "2.7";
3737
rocmVersion = "6.4.2";
3838
cxx11Abi = true;
3939
systems = [ "x86_64-linux" ];
40-
upstreamVariant = false;
40+
bundleBuild = false;
4141
}
4242

4343
{
4444
torchVersion = "2.7";
4545
cxx11Abi = true;
4646
metal = true;
4747
systems = [ "aarch64-darwin" ];
48-
upstreamVariant = true;
48+
bundleBuild = true;
4949
}
5050

5151
{
@@ -55,7 +55,7 @@
5555
systems = [
5656
"x86_64-linux"
5757
];
58-
upstreamVariant = true;
58+
bundleBuild = true;
5959
}
6060
{
6161
torchVersion = "2.8";
@@ -64,7 +64,7 @@
6464
systems = [
6565
"x86_64-linux"
6666
];
67-
upstreamVariant = true;
67+
bundleBuild = true;
6868
}
6969
{
7070
torchVersion = "2.8";
@@ -74,28 +74,28 @@
7474
"x86_64-linux"
7575
"aarch64-linux"
7676
];
77-
upstreamVariant = true;
77+
bundleBuild = true;
7878
}
7979
{
8080
torchVersion = "2.8";
8181
rocmVersion = "6.3.4";
8282
cxx11Abi = true;
8383
systems = [ "x86_64-linux" ];
84-
upstreamVariant = true;
84+
bundleBuild = true;
8585
}
8686
{
8787
torchVersion = "2.8";
8888
rocmVersion = "6.4.2";
8989
cxx11Abi = true;
9090
systems = [ "x86_64-linux" ];
91-
upstreamVariant = true;
91+
bundleBuild = true;
9292
}
9393
{
9494
torchVersion = "2.8";
9595
cxx11Abi = true;
9696
metal = true;
9797
systems = [ "aarch64-darwin" ];
98-
upstreamVariant = true;
98+
bundleBuild = true;
9999
}
100100

101101
# Non-standard versions; not included in bundle builds.

0 commit comments

Comments
 (0)