Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

feat: built root and user docker image variants#139

Merged
drbh merged 6 commits into
mainfrom
multi-permission-docker-images
May 30, 2025
Merged

feat: built root and user docker image variants#139
drbh merged 6 commits into
mainfrom
multi-permission-docker-images

Conversation

@drbh

@drbh drbh commented May 21, 2025

Copy link
Copy Markdown
Collaborator

This PR improves the docker built in various ways

  1. split dockerfile into root and non root builds
    • root for dev/ when the user has control over container launch
    • non root that expect uid 1000 to lock down permissions in CI/non rootless container envs
  2. bump workflow to publish both variants of containers
  3. prefer the --mount flag over the older --volume when launching the container for more granular permission control`

@drbh drbh marked this pull request as ready for review May 21, 2025 14:23
@drbh

drbh commented May 21, 2025

Copy link
Copy Markdown
Collaborator Author

example usage

git clone  https://github.com/huggingface/kernel-builder
cd kernel-builder
docker build -t kernel-builder:local -f dockerfiles/Dockerfile .
git clone https://huggingface.co/medmekk/rmsnorm_thrust
cd rmsnorm_thrust

then run the builder container build

docker run --mount type=bind,source=$(pwd),target=/kernelcode kernel-builder:local
# ...
# rmsnorm_kernel-torch-ext> ✅ No compatibility issues found
# building '/nix/store/1w31r5rj5d1f8pp0waamza4c72mlbqcm-torch-ext-bundle.drv'...
# Build completed. Copying results to /kernelcode/build
# Done - results available in /kernelcode/build

Comment thread dockerfiles/Dockerfile Outdated
@drbh drbh force-pushed the multi-permission-docker-images branch from 9144c56 to 4e25de5 Compare May 29, 2025 03:35
@drbh drbh merged commit 31c6e9b into main May 30, 2025
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants