This repository was archived by the owner on Apr 6, 2026. It is now read-only.
Update the build.toml format in preparation for Metal#144
Merged
Conversation
Changes: * `kernel.<name>.language` is removed. * `kernel.<name>.backend` is added and is one of `cuda` or `rocm`. * `torch.universal` is renamed to `general.universal`. * `.cu` files in kernels with the `rocm` backend are hipified. `build2toml` still parses the old format and adds a new `update-build` subcommand to upgrade a `build.toml`. The Nix tooling does not support the old format, but will suggest to run `build2toml update-build`.
drbh
approved these changes
May 27, 2025
drbh
left a comment
drbh
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me just added a syntax nit and a possible naming collision comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
kernel.<name>.languageis removed.kernel.<name>.backendis added and is one ofcudaorrocm.torch.universalis renamed togeneral.universal..cufiles in kernels with therocmbackend are hipified.build2tomlstill parses the old format and adds a newupdate-buildsubcommand to upgrade abuild.toml. The Nix tooling does not support the old format, but will suggest to runbuild2toml update-build.