This repository was archived by the owner on Apr 6, 2026. It is now read-only.
build2cmake: cxx-flags option for C++ compile flags for kernels#171
Merged
Conversation
MekkCyber
approved these changes
Jun 25, 2025
Comment on lines
+116
to
+123
| pub fn cxx_flags(&self) -> Option<&[String]> { | ||
| match self { | ||
| Kernel::Cuda { cxx_flags, .. } => cxx_flags.as_deref(), | ||
| Kernel::Metal { cxx_flags, .. } => cxx_flags.as_deref(), | ||
| Kernel::Rocm { cxx_flags, .. } => cxx_flags.as_deref(), | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
noob question : why not doing one match like this :
match self {
Kernel::Cuda { cxx_flags, .. }
| Kernel::Metal { cxx_flags, .. }
| Kernel::Rocm { cxx_flags, .. } => cxx_flags.as_deref(),
}
Member
Author
There was a problem hiding this comment.
Nicer indeed! Updated the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.