Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

Fix handling of the 9.0a and 12.0a capabilities#202

Merged
danieldk merged 1 commit into
mainfrom
fix-a-capability
Aug 29, 2025
Merged

Fix handling of the 9.0a and 12.0a capabilities#202
danieldk merged 1 commit into
mainfrom
fix-a-capability

Conversation

@danieldk

Copy link
Copy Markdown
Member

The code that computes the intersection between a kernel's capabilities and the supported capabilities failed because e.g. the base capability of 9.0a (9.0) did not match 9.0+PTX.

Instead we should just leave the supported capabilities at regular version numbers. Instead, make a list of default kernel capabilities and use that and intersect with the supported capabilities if no capabilities are specified for a kernel.

The code that computes the intersection between a kernel's capabilities
and the supported capabilities failed because e.g. the base capability
of 9.0a (9.0) did not match 9.0+PTX.

Instead we should just leave the supported capabilities at regular
version numbers. Instead, make a list of default kernel capabilities
and use that and intersect with the supported capabilities if no
capabilities are specified for a kernel.

@drbh drbh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieldk danieldk merged commit e6ffbc3 into main Aug 29, 2025
9 checks passed
@danieldk danieldk deleted the fix-a-capability branch August 29, 2025 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants