This repository was archived by the owner on Apr 6, 2026. It is now read-only.
Fix a regression in test shells#217
Merged
Merged
Conversation
The XPU support PR changed stdenv selection to choose the default stdenv when one of the kernels is an XPU kernel. However, this does not work for mixed XPU/CUDA projects, since we need to select the CUDA backend stdenv when building for CUDA. Change the logic to always use the stdenv for the backend that we are building for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XPU support PR changed stdenv selection to choose the default stdenv when one of the kernels is an XPU kernel. However, this does not work for mixed XPU/CUDA projects, since we need to select the CUDA backend stdenv when building for CUDA.
Change the logic to always use the stdenv for the backend that we are building for.