liger-kernels: sync with liger-kernels upstream#857
Merged
Conversation
danieldk
reviewed
May 15, 2026
| If the user did not specify the version tag, stop and ask which tag to sync | ||
| from. | ||
|
|
||
| ## liger-kernels |
vasqu
reviewed
May 15, 2026
| return loss | ||
|
|
||
|
|
||
| class LigerFusedLinearCrossEntropyLoss(nn.Module): |
Collaborator
There was a problem hiding this comment.
Could we also expose something like https://github.com/linkedin/Liger-Kernel/blob/38c0d4f8af6cc0386a4c798558e992570843f1ac/src/liger_kernel/transformers/model/loss_utils.py#L67 in the init? That's at least exactly what we are looking for in transformers then
I.e. we are looking into the base function we will exchange instead of the module
Collaborator
There was a problem hiding this comment.
Yep, looking good now, thanks!
Member
Author
vasqu
approved these changes
May 18, 2026
vasqu
reviewed
May 18, 2026
Comment on lines
+28
to
+33
| offset: float = 0.0, | ||
| casting_mode: str = "llama", | ||
| init_fn: str = "ones", | ||
| in_place: bool = True, | ||
| row_mode: Optional[bool] = None, | ||
| elementwise_affine: bool = True, |
Collaborator
There was a problem hiding this comment.
I think here we can ignore the extra init args and always default as done before?
Edit: Don't think it matters too much tho, should be fine as is as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update
AGENTS.mdto include Liger-Kernels specific instructions for syncing with the upstream.Cc: @vasqu