[ci] don't let vouch auto-close a pr re-opened by a maintainer.#880
Conversation
| steps: | ||
| - uses: mitchellh/vouch/action/check-pr@c6d80ead49839655b61b422700b7a3bc9d0804a9 # v1.4.2 | ||
| - name: Check if reopened by a maintainer | ||
| id: maintainer |
There was a problem hiding this comment.
Question, currently we use:
pull_request_target:
types: [opened, reopened]
Can an unprivileged user re-open a PR? If not, I think we can achieve the same by removing reopened above?
There was a problem hiding this comment.
Good point, but I think the PR author themselves can reopen their own PR even without write access (per GitHub's permission model — anyone who opens a PR can close/reopen it). So if we drop reopened, an unvouched author could reopen the auto-closed PR and it would stay open without re-triggering the check.
That said, if that's an acceptable trade-off (closing once on opened is enough as a signal), removing reopened would indeed be the simpler fix.
LMK which route you would prefer.
There was a problem hiding this comment.
Ah, that's annoying, let's do it as in your PR then.
2 participants
No description provided.