Skip to content

scripts/check_kernel_freshness: include kernel_dir in stale report items#889

Closed
Dev-X25874 wants to merge 2 commits into
huggingface:mainfrom
Dev-X25874:fix/freshness-report-missing-kernel-dir
Closed

scripts/check_kernel_freshness: include kernel_dir in stale report items#889
Dev-X25874 wants to merge 2 commits into
huggingface:mainfrom
Dev-X25874:fix/freshness-report-missing-kernel-dir

Conversation

@Dev-X25874
Copy link
Copy Markdown

Closes #879

What does this PR do?

Adds kernel_dir to each line in the Slack freshness report so stale alerts identify which local directory needs updating, not just the upstream URL.

Motivation

Several kernels share the same upstream URL. For example flash-attn2, flash-attn3, flash-attn4, layer-norm, rotary, and vllm-flash-attn3 all point to the same flash-attention repo. When any go stale, the current report prints the same URL multiple times with no indication of which directory is behind, making the alert unactionable. The kernel_dir key is already populated in every result dict — it was just never used when building the output string.

Changes

  • scripts/check_kernel_freshness.py: one-line format string change in _format_freshness_report to prepend kernel_dir to each report line
  • scripts/test_kernel_freshness_lookup.py: added test_freshness_report_includes_kernel_dir — calls _format_freshness_report with two results sharing a source URL, asserts both kernel_dir values appear in the output

Testing

cd scripts
python test_kernel_freshness_lookup.py

New test fails on original code, passes after the fix.

Checklist

  • This PR is linked to an issue that was discussed and approved
  • I have tested these changes locally
  • New/changed functionality has test coverage
  • LLM disclosure:
    • I did not use an LLM to create this PR.
    • I used an LLM for assistance while creating this PR.
    • This PR was mostly or completely generated by an LLM.

@Dev-X25874 Dev-X25874 requested review from danieldk and drbh as code owners May 26, 2026 02:50
@github-actions
Copy link
Copy Markdown

Hi @Dev-X25874, thanks for your interest in contributing!

This project requires that pull request authors are vouched, and you are not in the list of vouched users.

This PR will be closed automatically. See https://github.com/huggingface/kernels-community/blob/main/CONTRIBUTING.md for more details.

@github-actions github-actions Bot closed this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/check_kernel_freshness: freshness report omits kernel_dir, making stale alerts unactionable

1 participant