scripts/check_kernel_freshness: include kernel_dir in stale report items#889
Closed
Dev-X25874 wants to merge 2 commits into
Closed
scripts/check_kernel_freshness: include kernel_dir in stale report items#889Dev-X25874 wants to merge 2 commits into
Dev-X25874 wants to merge 2 commits into
Conversation
|
Hi @Dev-X25874, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/huggingface/kernels-community/blob/main/CONTRIBUTING.md for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #879
What does this PR do?
Adds
kernel_dirto each line in the Slack freshness report so stale alerts identify which local directory needs updating, not just the upstream URL.Motivation
Several kernels share the same upstream URL. For example
flash-attn2,flash-attn3,flash-attn4,layer-norm,rotary, andvllm-flash-attn3all point to the same flash-attention repo. When any go stale, the current report prints the same URL multiple times with no indication of which directory is behind, making the alert unactionable. Thekernel_dirkey is already populated in every result dict — it was just never used when building the output string.Changes
scripts/check_kernel_freshness.py: one-line format string change in_format_freshness_reportto prependkernel_dirto each report linescripts/test_kernel_freshness_lookup.py: addedtest_freshness_report_includes_kernel_dir— calls_format_freshness_reportwith two results sharing a source URL, asserts bothkernel_dirvalues appear in the outputTesting
cd scripts python test_kernel_freshness_lookup.pyNew test fails on original code, passes after the fix.
Checklist