Skip to content

rotary: Refactor split into separate files + warning in readme#949

Open
vasqu wants to merge 19 commits into
mainfrom
update-rotary
Open

rotary: Refactor split into separate files + warning in readme#949
vasqu wants to merge 19 commits into
mainfrom
update-rotary

Conversation

@vasqu

@vasqu vasqu commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

As per title, successor to #929 but using direct branches and not a fork to have proper CI

  • Adds a warning to the card as the kernel is outdated / not maintained anymore
  • Split the func specifics to layer (should be done sooner or later)

@danieldk

Copy link
Copy Markdown
Member

The build currently fails:

       >   File "/nix/store/009nfcf16mly93zr54yywrjisv1ngpbj-rotary-torch-ext/torch212-cxx11-cu126-x86_64-linux/__init__.py", line 4, in <module>
       >     from .layers import apply_rotary_transformers
       >   File "/nix/store/009nfcf16mly93zr54yywrjisv1ngpbj-rotary-torch-ext/torch212-cxx11-cu126-x86_64-linux/layers.py", line 3, in <module>
       >     from . import apply_rotary
       > ImportError: cannot import name 'apply_rotary' from '_rotary_cuda_73f4e9f' (/nix/store/009nfcf16mly93zr54yywrjisv1ngpbj-rotary-torch-ext/torch212-cxx11-cu126-x86_64-linux/__init__.py)

@vasqu

vasqu commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Will check, probably some wrong relative import. Should be straightforward

Comment thread rotary/torch-ext/rotary/__init__.py Outdated
@vasqu vasqu requested a review from danieldk June 15, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants