Skip to content

Commit 46b2896

Browse files
committed
Fix torchVersions argument of genKernelFlakeOutputs (#246)
* Fix `torchVersions` argument of `genKernelFlakeOutputs` * Do not add build for every by system to `lib` in kernel flake output * Fix
1 parent 2ad7c76 commit 46b2896

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

builder/lib/build-sets.nix

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
nixpkgs,
33
rust-overlay,
4-
torchVersions,
54
}:
65

76
let
@@ -16,7 +15,7 @@ let
1615

1716
# All build configurations supported by Torch.
1817
buildConfigs =
19-
system:
18+
torchVersions: system:
2019
let
2120
filterMap = f: xs: builtins.filter (x: x != null) (builtins.map f xs);
2221
systemBuildConfigs = filterMap (version: if version.system == system then version else null) (
@@ -30,7 +29,8 @@ let
3029
in
3130
rec {
3231
mkBuildSets =
33-
systems: lib.concatMap (system: builtins.map mkBuildSet (buildConfigs system)) systems;
32+
torchVersions: systems:
33+
lib.concatMap (system: builtins.map mkBuildSet (buildConfigs torchVersions system)) systems;
3434

3535
# Partition into an attrset { <system> = [ <buildset> ...]; ... }.
3636
partitionBuildSetsBySystem = lib.foldl (

flake.nix

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
inherit
2424
(import ./builder/lib/build-sets.nix {
2525
inherit nixpkgs rust-overlay;
26-
torchVersions = torchVersions';
2726
})
2827
mkBuildSets
2928
partitionBuildSetsBySystem
@@ -39,7 +38,7 @@
3938

4039
torchVersions' = import ./builder/versions.nix;
4140

42-
defaultBuildSets = mkBuildSets systems;
41+
defaultBuildSets = mkBuildSets torchVersions' systems;
4342
defaultBuildSetsPerSystem = partitionBuildSetsBySystem defaultBuildSets;
4443

4544
mkBuildPerSystem =
@@ -90,7 +89,7 @@
9089
(builtins.isFunction torchVersions)
9190
|| abort "`torchVersions` must be a function taking one argument (the default version set)";
9291
let
93-
buildSets = mkBuildSets systems;
92+
buildSets = mkBuildSets (torchVersions torchVersions') systems;
9493
buildSetPerSystem = partitionBuildSetsBySystem buildSets;
9594
buildPerSystem = mkBuildPerSystem buildSetPerSystem;
9695
in
@@ -110,8 +109,8 @@
110109
buildSets = buildSetPerSystem.${system};
111110
}
112111
);
113-
}
114-
// defaultBuildPerSystem;
112+
};
113+
#// defaultBuildPerSystem;
115114
in
116115
flake-utils.lib.eachSystem systems (
117116
system:

0 commit comments

Comments
 (0)