Skip to content

Commit 62e096f

Browse files
authored
kernel-builder: use tag argument instead of rev for tags in fetchFromGitHub (#432)
The tag argument is prefixed with refs/tags/ to construct the full rev in fetchgit[1], preventing rev confusion (e.g. where a branch and a tag have the same name), thus it's recommended to use the tag argument over the rev argument for tags. [1] https://github.com/NixOS/nixpkgs/blob/55d32361d6c1f304e6c88a0dbebb19fb1044bbd7/pkgs/build-support/fetchgit/default.nix#L31 Signed-off-by: Nick Cao <ncao@redhat.com>
1 parent 205a554 commit 62e096f

6 files changed

Lines changed: 7 additions & 7 deletions

File tree

nix-builder/pkgs/aotriton/default.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ in
3838
src = fetchFromGitHub {
3939
owner = "ROCm";
4040
repo = "aotriton";
41-
rev = version;
41+
tag = version;
4242
hash = "sha256-F7JjyS+6gMdCpOFLldTsNJdVzzVwd6lwW7+V8ZOZfig=";
4343
leaveDotGit = true;
4444
inherit postFetch;
@@ -92,7 +92,7 @@ in
9292
src = fetchFromGitHub {
9393
owner = "ROCm";
9494
repo = "aotriton";
95-
rev = version;
95+
tag = version;
9696
hash = "sha256-VIwwQR1fl40NLNOwO8KhQK/xOK6wb2l8qBugJ1cRjm4=";
9797
leaveDotGit = true;
9898
inherit postFetch;

nix-builder/pkgs/cutlass/builder.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ cudaPackages.backendStdenv.mkDerivation rec {
1818
src = fetchFromGitHub {
1919
owner = "NVIDIA";
2020
repo = pname;
21-
rev = "v${version}";
21+
tag = "v${version}";
2222
inherit hash;
2323
};
2424

nix-builder/pkgs/nvtx/default.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ stdenv.mkDerivation (finalAttrs: {
1111
src = fetchFromGitHub {
1212
owner = "NVIDIA";
1313
repo = "NVTX";
14-
rev = "v${finalAttrs.version}";
14+
tag = "v${finalAttrs.version}";
1515
hash = "sha256-MXluy/I5+SaRx2aF64qF4XZ+u67ERAB9TftbOvYt4GE=";
1616
};
1717

nix-builder/pkgs/python-modules/cuda-pathfinder/default.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ buildPythonPackage rec {
1212
src = fetchFromGitHub {
1313
owner = "NVIDIA";
1414
repo = "cuda-python";
15-
rev = "${pname}-v${version}";
15+
tag = "${pname}-v${version}";
1616
hash = "sha256-aF06WwThJmGEqUcVP4dooym1uqYjUM45arqZaxjlTuA=";
1717
};
1818

nix-builder/pkgs/python-modules/cuda-python/default.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ buildPythonPackage rec {
1717
src = fetchFromGitHub {
1818
owner = "NVIDIA";
1919
repo = "cuda-python";
20-
rev = "v${version}";
20+
tag = "v${version}";
2121
hash = "sha256-AvIw2G4EGWsX7PxFGxzECXhwkbwYslHzRdUArTNf7jE=";
2222
};
2323

nix-builder/pkgs/python-modules/tvm-ffi/default.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ buildPythonPackage rec {
1919
src = fetchFromGitHub {
2020
owner = "apache";
2121
repo = "tvm-ffi";
22-
rev = "v${version}";
22+
tag = "v${version}";
2323
hash = "sha256-XnlM//WW2TbjbmzYBq6itJQ7R3J646UMVQUVhV5Afwc=";
2424
fetchSubmodules = true;
2525
};

0 commit comments

Comments
 (0)