Skip to content

Factor out render_deps function #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldk merged 8 commits into from
Jan 30, 2026
Merged

Factor out render_deps function #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01bb2c7
build2cmake: always generate kernel components for all backends
danieldk Jan 28, 2026
2609a3f
Factor out `write_torch_registration_macros` to `common` mod
danieldk Jan 28, 2026
0c9b25d
Move `write_ops_py` to `common` mod
danieldk Jan 28, 2026
5f4d27b
Factor out CMake helper file generation
danieldk Jan 28, 2026
48d2cd6
Merge remote-tracking branch 'origin/main' into move-cmake-to-common
danieldk Jan 29, 2026
8aeda6e
Merge remote-tracking branch 'origin/main' into move-cmake-to-common
danieldk Jan 29, 2026
e4f46f1
Factor out `render_deps` function
danieldk Jan 29, 2026
f43eb47
Merge remote-tracking branch 'origin/main' into refactor-render-deps
danieldk Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 2 additions & 97 deletions build2cmake/src/torch/cuda.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
use std::collections::HashSet;
use std::env;
use std::io::Write;
use std::path::PathBuf;

use eyre::{bail, Context, Result};
use minijinja::{context, Environment};

use crate::config::{Backend, Build, Dependency, Torch};
use crate::config::{Backend, Build, Torch};
use crate::torch::common::{
render_binding, render_extension, write_cmake_helpers, write_metadata, write_ops_py,
write_pyproject_toml, write_setup_py, write_torch_registration_macros,
};
use crate::torch::deps::render_deps;
use crate::torch::kernel::render_kernel_components;
use crate::torch::kernel_ops_identifier;
use crate::version::Version;
Expand Down Expand Up @@ -95,101 +95,6 @@ fn write_cmake(
Ok(())
}

fn render_deps(
env: &Environment,
backend: Backend,
build: &Build,
write: &mut impl Write,
) -> Result<()> {
let mut deps = HashSet::new();

for kernel in build
.kernels
.values()
.filter(|kernel| kernel.backend() == backend)
{
deps.extend(kernel.depends());
}

for dep in deps {
match dep {
Dependency::Cutlass2_10 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "2.10.0",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass3_5 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "3.5.1",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass3_6 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "3.6.0",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass3_8 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "3.8.0",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass3_9 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "3.9.2",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass4_0 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "4.0.0",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Torch => (),
_ => {
eprintln!("Warning: CUDA backend doesn't need/support dependency: {dep:?}");
}
};
write.write_all(b"\n")?;
}

Ok(())
}

pub fn render_preamble(
env: &Environment,
name: &str,
Expand Down
106 changes: 106 additions & 0 deletions build2cmake/src/torch/deps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
use std::collections::HashSet;
use std::io::Write;

use eyre::{Context, Result};
use minijinja::{context, Environment};

use crate::config::{Backend, Build, Dependency};

pub fn render_deps(
env: &Environment,
backend: Backend,
build: &Build,
write: &mut impl Write,
) -> Result<()> {
let mut deps = HashSet::new();

for kernel in build
.kernels
.values()
.filter(|kernel| kernel.backend() == backend)
{
deps.extend(kernel.depends());
}

for dep in deps {
match dep {
Dependency::Cutlass2_10 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "2.10.0",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass3_5 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "3.5.1",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass3_6 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "3.6.0",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass3_8 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "3.8.0",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass3_9 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "3.9.2",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::Cutlass4_0 => {
env.get_template("cuda/dep-cutlass.cmake")
.wrap_err("Cannot get CUTLASS dependency template")?
.render_to_write(
context! {
version => "4.0.0",
},
&mut *write,
)
.wrap_err("Cannot render CUTLASS dependency template")?;
}
Dependency::CutlassSycl => {
env.get_template("xpu/dep-cutlass-sycl.cmake")?
.render_to_write(context! {}, &mut *write)?;
}
Dependency::Torch => (),
_ => {
eprintln!("Warning: {backend:?} backend doesn't need/support dependency: {dep:?}");
}
}
write.write_all(b"\n")?;
}

Ok(())
}
2 changes: 2 additions & 0 deletions build2cmake/src/torch/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ pub use cuda::write_torch_ext_cuda;

pub mod common;

pub(crate) mod deps;

pub mod kernel;

mod metal;
Expand Down
38 changes: 2 additions & 36 deletions build2cmake/src/torch/xpu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
use std::collections::HashSet;
use std::io::Write;
use std::path::PathBuf;

use eyre::{bail, Context, Result};
use minijinja::{context, Environment};

use crate::config::{Backend, Build, Dependency, Torch};
use crate::config::{Backend, Build, Torch};
use crate::torch::common::{
render_binding, render_extension, write_cmake_helpers, write_metadata, write_ops_py,
write_pyproject_toml, write_setup_py, write_torch_registration_macros,
};
use crate::torch::deps::render_deps;
use crate::torch::kernel::render_kernel_components;
use crate::torch::kernel_ops_identifier;
use crate::version::Version;
Expand Down Expand Up @@ -89,40 +89,6 @@ fn write_cmake(
Ok(())
}

fn render_deps(
env: &Environment,
backend: Backend,
build: &Build,
write: &mut impl Write,
) -> Result<()> {
let mut deps = HashSet::new();

for kernel in build
.kernels
.values()
.filter(|kernel| kernel.backend() == backend)
{
deps.extend(kernel.depends());
}

for dep in deps {
match dep {
Dependency::CutlassSycl => {
env.get_template("xpu/dep-cutlass-sycl.cmake")?
.render_to_write(context! {}, &mut *write)?;
}
Dependency::Torch => (),
_ => {
// XPU supports CUTLASS-SYCL instead of CUTLASS
eprintln!("Warning: XPU backend doesn't need/support dependency: {dep:?}");
}
}
write.write_all(b"\n")?;
}

Ok(())
}

pub fn render_preamble(
env: &Environment,
name: &str,
Expand Down
Loading