Remove backend-specific generation and also use CMake variant generation in Nix#259
Merged
Remove backend-specific generation and also use CMake variant generation in Nix#259
Conversation
We now always add the dependencies to the file, but as extras to be used for the backend that is used.
Also remove the backend option from the `generate-torch` subcommand.
This makes some newer Python tooling happy.
The XPU build would fail in some cases, e.g. when using sycl-cutlass. The compiler detection really needs to be done before the CMake project is defined.
danieldk
force-pushed
the
remove-backend
branch
from
fd5dd4f to
17584dd
Compare
This was supported by the Nix builder before, but not the Windows builder.
danieldk
force-pushed
the
remove-backend
branch
from
17584dd to
a99cc41
Compare
drbh
approved these changes
Feb 5, 2026
| return json.load(f) | ||
|
|
||
|
|
||
| EASTER_EGG = _read_json() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines several changes that are mostly co-dependent:
--backendoption frombuild2cmake, we now generate aCMakeLists.txtthat works with all backends. The backend is determined by querying PyTorch.result/<variant-name>/in place ofresult/.PYTHONPATHfor better impure tests.