feat: enforce strict kernel name#290
Merged
Merged
Conversation
danieldk
reviewed
Feb 17, 2026
Comment on lines
+215
to
+232
| fn validate_name(name: &str) -> Result<()> { | ||
| // Pattern requires at least 2 characters: start letter + end letter/digit | ||
| let pattern = Regex::new(r"^[a-z][-a-z0-9]*[a-z0-9]$").expect("Invalid regex pattern"); | ||
|
|
||
| if !pattern.is_match(name) { | ||
| bail!( | ||
| "Invalid kernel name `{name}`. Name must:\n\ | ||
| - Start with a lowercase letter (a-z)\n\ | ||
| - Contain only lowercase letters, digits, and dashes\n\ | ||
| - End with a lowercase letter or digit\n\ | ||
| - Be at least 2 characters long\n\ | ||
| Examples: `my-kernel`, `relu2d`, `flash-attention`" | ||
| ); | ||
| } | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Really nice! I like strong typing, maybe we could have a KernelName type where the constructor/deserializer does the validation? In that way we can guarantee that it's validated everywhere.
Collaborator
Author
There was a problem hiding this comment.
great idea, will update shortly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enforces that kernel names: