pass revision to to cmake template#291
Merged
Merged
Conversation
danieldk
approved these changes
Feb 18, 2026
Member
danieldk
left a comment
There was a problem hiding this comment.
Great catch! Merging immediately, since we are often building using main.
danieldk
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the ops id was not passed to render_preamble, causing it to fall back to a different identifier in Nix builds. This made the cmake extension name diverge from the expected name.
Additionally, the postInstall cleanup pattern was missing the backend segment, so stale build artifacts were not removed. Together these caused build-and-copy to fail with Permission denied when bundling multiple variants.
error when using the builder on main
example of build output when using an older version of the builder that didnt cause the collision but didnt clean up the build artifacts
example build after changes
note: upon further investigation the collision seems to happen after #281 which seemed to result in the same identifier being used in multiple variants which resulted in a conflict in the join-paths merge. the changes in this PR avoid this bug and result in a reliable build output