fix/rocm properties export#487
Open
GitGlimpse895 wants to merge 4 commits intohuggingface:mainfrom
Open
Conversation
GitGlimpse895
force-pushed
the
fix/rocm-properties-export
branch
4 times, most recently
from
65ef442 to
ae0a6eb
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
GitGlimpse895
force-pushed
the
fix/rocm-properties-export
branch
from
441d889 to
f98c3ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROCMPropertieswas fully implemented indevice.pywith its own docstring and example, but was never wired up end-to-end:Device.propertieswas typed asCUDAProperties | None, silently rejectingROCMPropertiesat the type-system level.Device.__post_init__validatedCUDAPropertiesplacement but had no symmetric guard forROCMProperties, allowing invalid combinations likeDevice(type="cuda", properties=ROCMProperties(...))to pass silently.ROCMPropertieswas never exported fromkernels/layer/__init__.pyor the top-levelkernels/__init__.py, makingfrom kernels import ROCMPropertiesfail despite being shown in the class docstring example.This PR fixes all three gaps across three files, completing the ROCm capability-range kernel selection feature that was already wired up in
_ROCMRepos.