Skip to content

Fix update tests for kernel data lib and path and add ci rust tests#514

Merged
danieldk merged 4 commits intomainfrom
fix-update-tests-for-kernel-data-lib
May 1, 2026
Merged

Fix update tests for kernel data lib and path and add ci rust tests#514
danieldk merged 4 commits intomainfrom
fix-update-tests-for-kernel-data-lib

Conversation

@drbh
Copy link
Copy Markdown
Collaborator

@drbh drbh commented Apr 30, 2026

This PR simply updates the tests since they were failing due to the new kernel-data library and a bad path for the e2e tests

cargo test -p hf-kernel-builder
   Compiling hf-kernel-builder v0.14.0-dev1 (/Users/drbh/Projects/kernels/kernel-builder)
    Finished [`test` profile [unoptimized + debuginfo]](https://doc.rust-lang.org/cargo/reference/profiles.html#default-profiles) target(s) in 0.28s
     Running unittests src/main.rs (target/debug/deps/kernel_builder-38c44aa6fab662b1)

running 27 tests
test card::tests::test_extract_functions_missing ... ok
test card::tests::test_extract_functions_excludes_layers ... ok
test upload::tests::test_collect_benchmark_commit_ops_delete_stale ... ok
test card::tests::test_extract_functions ... ok
test upload::tests::test_collect_benchmark_commit_ops ... ok
test upload::tests::test_collect_build_commit_ops_deletes_stale ... ok
test card::tests::test_extract_layers_missing_file ... ok
test upload::tests::test_collect_readme_commit_ops ... ok
test upload::tests::test_collect_build_commit_ops_new_branch_deletes_all ... ok
test card::tests::test_extract_functions_only_layers ... ok
test card::tests::test_extract_functions_multiline ... ok
test upload::tests::test_args_take_priority_over_files ... ok
test upload::tests::test_collect_readme_commit_ops_no_card ... ok
test upload::tests::test_discover_build_file_not_found ... ok
test upload::tests::test_collect_build_commit_ops ... ok
test util::tests::test_discover_variants_no_variants ... ok
test upload::tests::test_discover_build_file_in_fully_specified_build_dir ... ok
test upload::tests::test_discover_build_file_in_build ... ok
test upload::tests::test_detect_branch_from_metadata ... ok
test card::tests::test_extract_layers_not_in_all ... ok
test upload::tests::test_branch_from_build_toml ... ok
test upload::tests::test_detect_branch_from_metadata_v0 ... ok
test card::tests::test_extract_layers ... ok
test upload::tests::test_discover_build_file_in_result_symlink ... ok
test upload::tests::test_detect_branch_from_metadata_mismatched_versions ... ok
test util::tests::test_discover_variants_from_result_symlink ... ok
test util::tests::test_discover_variants ... ok

test result: ok. 27 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

     Running tests/init_e2e.rs (target/debug/deps/init_e2e-4d1304e2a31c5304)

running 4 tests
test test_init_fails_on_existing_scaffold_file ... ok
test test_init_templates_rendered ... ok
test test_init_creates_expected_files ... ok
test test_init_overwrite ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.97s

and before the changes

cargo test -p hf-kernel-builder
   Compiling hf-kernel-builder v0.14.0-dev1 (/Users/drbh/Projects/kernels/kernel-builder)
    Finished [`test` profile [unoptimized + debuginfo]](https://doc.rust-lang.org/cargo/reference/profiles.html#default-profiles) target(s) in 0.90s
     Running unittests src/main.rs (target/debug/deps/kernel_builder-38c44aa6fab662b1)

running 27 tests
test card::tests::test_extract_functions_missing ... ok
test upload::tests::test_collect_benchmark_commit_ops_delete_stale ... ok
test card::tests::test_extract_functions_excludes_layers ... ok
test card::tests::test_extract_layers_missing_file ... ok
test card::tests::test_extract_functions_only_layers ... ok
test upload::tests::test_collect_build_commit_ops_deletes_stale ... ok
test upload::tests::test_collect_build_commit_ops_new_branch_deletes_all ... ok
test card::tests::test_extract_functions_multiline ... ok
test upload::tests::test_collect_readme_commit_ops_no_card ... ok
test upload::tests::test_collect_build_commit_ops ... ok
test card::tests::test_extract_functions ... ok
test card::tests::test_extract_layers ... ok
test upload::tests::test_discover_build_file_not_found ... ok
test card::tests::test_extract_layers_not_in_all ... ok
test upload::tests::test_collect_benchmark_commit_ops ... ok
test upload::tests::test_discover_build_file_in_build ... ok
test util::tests::test_discover_variants_no_variants ... ok
test upload::tests::test_collect_readme_commit_ops ... ok
test upload::tests::test_detect_branch_from_metadata ... FAILED
test upload::tests::test_detect_branch_from_metadata_no_version ... FAILED
test upload::tests::test_discover_build_file_in_fully_specified_build_dir ... ok
test upload::tests::test_args_take_priority_over_files ... ok
test upload::tests::test_branch_from_build_toml ... FAILED
test upload::tests::test_discover_build_file_in_result_symlink ... ok
test upload::tests::test_detect_branch_from_metadata_mismatched_versions ... ok
test util::tests::test_discover_variants_from_result_symlink ... ok
test util::tests::test_discover_variants ... ok

failures:

---- upload::tests::test_detect_branch_from_metadata stdout ----

thread 'upload::tests::test_detect_branch_from_metadata' (10480561) panicked at kernel-builder/src/upload.rs:612:61:
called `Result::unwrap()` on an `Err` value: missing field `name` at line 1 column 84

Location:
    kernels-data/src/metadata.rs:33:12

---- upload::tests::test_detect_branch_from_metadata_no_version stdout ----

thread 'upload::tests::test_detect_branch_from_metadata_no_version' (10480563) panicked at kernel-builder/src/upload.rs:624:61:
called `Result::unwrap()` on an `Err` value: missing field `name` at line 1 column 70

Location:
    kernels-data/src/metadata.rs:33:12

---- upload::tests::test_branch_from_build_toml stdout ----

thread 'upload::tests::test_branch_from_build_toml' (10480553) panicked at kernel-builder/src/upload.rs:730:88:
called `Result::unwrap()` on an `Err` value: --repo-id is not provided and cannot parse build.toml.

Caused by:
   0: Cannot update build configuration
   1: Cannot migrate configuration: "The `license` key is required in the `general` section"

Location:
    kernel-builder/src/util.rs:15:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    upload::tests::test_branch_from_build_toml
    upload::tests::test_detect_branch_from_metadata
    upload::tests::test_detect_branch_from_metadata_no_version

test result: FAILED. 24 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

error: test failed, to rerun pass `-p hf-kernel-builder --bin kernel-builder`

@danieldk danieldk merged commit 9b7c2e6 into main May 1, 2026
68 of 69 checks passed
@danieldk danieldk deleted the fix-update-tests-for-kernel-data-lib branch May 1, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants