Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/build_kernel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,19 @@ on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "nix-builder/**"
- "kernel-builder/**"
- "examples/kernels/**"
- "**/*.nix"
- "**/flake.lock"
- ".github/workflows/build_kernel.yaml"
Comment on lines +9 to +14
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see any other dependency.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Other Rust parts (kernel-abi-check, kernels-data).
  • The kernels Python package (to validate that get_kernel works correctly as a post-build hook).

In other words, pretty much everything.

workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
name: Build kernels (${{ matrix.arch }})
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/build_kernel_macos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,19 @@ on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "nix-builder/**"
- "kernel-builder/**"
- "examples/kernels/**"
- "**/*.nix"
- "**/flake.lock"
- ".github/workflows/build_kernel_macos.yaml"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
name: Build kernel
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/build_kernel_rocm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,19 @@ on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "nix-builder/**"
- "kernel-builder/**"
- "examples/kernels/**"
- "**/*.nix"
- "**/flake.lock"
- ".github/workflows/build_kernel_rocm.yaml"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
name: Build kernel
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/build_kernel_windows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,19 @@ on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "nix-builder/**"
- "kernel-builder/**"
- "examples/kernels/**"
- "**/*.nix"
- "**/flake.lock"
- ".github/workflows/build_kernel_windows.yaml"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not dependent on nix-builder, apart from that, see above.

workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
strategy:
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/build_kernel_xpu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,19 @@ on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "nix-builder/**"
- "kernel-builder/**"
- "examples/kernels/**"
- "**/*.nix"
- "**/flake.lock"
- ".github/workflows/build_kernel_xpu.yaml"
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
name: Build kernel
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/check_variants.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,18 @@ on:
pull_request:
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any dependency on kernel-builder changes?

branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "nix-builder/**"
- "**/*.nix"
- "**/flake.lock"
- "docs/source/builder/build-variants.md"
- ".github/workflows/check_variants.yaml"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is really cheap, so I think it's better not to run the risk of missing a dependency.

workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
name: Check build variants
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/kernel-builder-cli-docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
branches:
- main

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
check-cli-docs:
runs-on: ubuntu-latest
Expand Down
15 changes: 12 additions & 3 deletions .github/workflows/kernel_abi_python_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,20 @@ on:
tags:
- "*"
pull_request:
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "kernel-abi-check/**"
- "Cargo.toml"
- "Cargo.lock"
- ".github/workflows/kernel_abi_python_release.yaml"
workflow_dispatch:

concurrency:
# Hardcoded prefix because this workflow shares `name: CI` with
# kernels_data_python_release.yaml; ${{ github.workflow }} would
# otherwise collide and cancel the sibling workflow's run.
group: kernel-abi-python-release-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

permissions:
contents: read

Expand Down
19 changes: 15 additions & 4 deletions .github/workflows/kernels_data_python_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
# - manifest paths made relative
# - publish step switched from `uv publish` + API token to
# `PyO3/maturin-action` + PyPI trusted publishing (see plan.md §3a, §3b)
# - pull_request trigger gained `paths-ignore` for docs-only PRs
# - pull_request trigger scoped to kernels-data/** and Cargo.{toml,lock}
# so unrelated PRs don't trigger the full wheel matrix
# - added concurrency cancellation for in-progress PR builds
name: CI

on:
Expand All @@ -18,11 +20,20 @@ on:
tags:
- "*"
pull_request:
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "kernels-data/**"
- "Cargo.toml"
- "Cargo.lock"
- ".github/workflows/kernels_data_python_release.yaml"
workflow_dispatch:

concurrency:
# Hardcoded prefix because this workflow shares `name: CI` with
# kernel_abi_python_release.yaml; ${{ github.workflow }} would
# otherwise collide and cancel the sibling workflow's run.
group: kernels-data-python-release-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

permissions:
contents: read

Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
name: Lints
on:
push:
branches: [main]
pull_request:
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "kernels/**"
- "kernels-data/src/python_dependencies.json"
- ".github/workflows/lint.yml"

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

env:
RUFF_VERSION: "0.15.10"
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/nix_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,19 @@ on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "nix-builder/**"
- "kernel-builder/**"
- "examples/kernels/**"
- "**/*.nix"
- "**/flake.lock"
- ".github/workflows/nix_checks.yml"
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
name: Nix checks
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/publish_kernels.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: Publish Python 🐍 distribution 📦 to PyPI and TestPyPI

on: push
on:
push:
branches: [main]
tags:
- "*"

jobs:
build:
Expand Down
19 changes: 16 additions & 3 deletions .github/workflows/rust.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,19 @@ name: Rust

on:
push:
branches: [main]
pull_request:
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "kernel-abi-check/**"
- "kernels-data/**"
- "kernel-builder/**"
- "Cargo.toml"
- "Cargo.lock"
- ".github/workflows/rust.yaml"

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
fmt:
Expand Down Expand Up @@ -41,6 +50,8 @@ jobs:
~/.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
restore-keys: |
${{ runner.os }}-cargo-
- uses: dtolnay/rust-toolchain@e081816240890017053eacbb1bdf337761dc5582 # 1.95.0
with:
components: clippy
Expand Down Expand Up @@ -69,6 +80,8 @@ jobs:
~/.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
restore-keys: |
${{ runner.os }}-cargo-
- uses: dtolnay/rust-toolchain@e081816240890017053eacbb1bdf337761dc5582 # 1.95.0
- name: Test (kernel-abi-check)
run: cargo test -p kernel-abi-check
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/test_extra_commands.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,19 @@ on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "nix-builder/**"
- "kernel-builder/**"
- "examples/kernels/**"
- "**/*.nix"
- "**/flake.lock"
- ".github/workflows/test_extra_commands.yaml"
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
name: Build kernel
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/test_kernels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "kernels/**"
- "kernels-data/bindings/python/**"
- "kernel-abi-check/bindings/python/**"
- ".github/workflows/test_kernels.yaml"
Comment on lines +9 to +13
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any dependency on kernel-builder here. So, we probably shouldn't trigger it when changes are made to kernel-builder, nix-builder, etc.

workflow_dispatch:

concurrency:
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/test_python.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened] # trigger on PRs
paths-ignore:
- "docs/**"
- "*.md"
paths:
- "kernel-abi-check/**"
- "kernels-data/**"
- ".github/workflows/test_python.yaml"
workflow_dispatch:

concurrency:
Expand Down
Loading