Wrap vllm inputs to compatible with VLLM>=0.10.2#1003
Open
JIElite wants to merge 2 commits intohuggingface:mainfrom
Open
Wrap vllm inputs to compatible with VLLM>=0.10.2#1003JIElite wants to merge 2 commits intohuggingface:mainfrom
JIElite wants to merge 2 commits intohuggingface:mainfrom
Conversation
Collaborator
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Hey @JIElite — your analysis in #1002 was right on the money. #1173 landed in the meantime and handled the bulk of the upgrade. There were still a couple of leftover wrapping patterns though, so I put up #1191 to clean those out. Turns out PromptType takes list[int] directly now so the wrapping was just unnecessary overhead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented the code to support VLLM>=0.10.2 as mentioned in issue #1002, so that we can evaluate the newest models with lighteval.
Please take a look.
Thank you.