Skip to content

[NNCF] Update test references for NNCF 3.1.0#1678

Open
andrey-churkin wants to merge 2 commits intohuggingface:mainfrom
andrey-churkin:ac/nncf_3.1.0
Open

[NNCF] Update test references for NNCF 3.1.0#1678
andrey-churkin wants to merge 2 commits intohuggingface:mainfrom
andrey-churkin:ac/nncf_3.1.0

Conversation

@andrey-churkin
Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Updates the minimum required version of NNCF to 3.1.0
  • Updates test references to align with the desired changes in NNCF

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

"opt125m",
"mxfp4",
{"model": {"int8": 4, "f4e2m1": 72, "f8e8m0": 72}},
{"model": {"int8": 0, "f4e2m1": 72, "f8e4m3": 2, "f8e8m0": 74}},
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was it changed and now there is no int8 coeffs?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently merged a new feature into NNCF. Please see the openvinotoolkit/nncf#3886. The references have been updated to reflect the current state.

Comment thread setup.py
"transformers>=4.45,<4.58",
"setuptools",
"nncf>=2.19.0",
"nncf>=3.1.0",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it recommended to install 3.1.0 by default? Do we have any model requires it? Please recommend.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped the minimum nncf version to 3.1.0 because there is a test that passes only with nncf ≥ 3.1.0, and the default behavior of the --backup-precision parameter was extended in that release. Please see the updated docs.

Copy link
Copy Markdown
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us move to the latest OV. After that we will merge this PR

Copy link
Copy Markdown
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrey-churkin, please rebase your PR. We recently merged PR to move to the latest OpenVINO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants