[EXPERIMENT][WIP] Add SmolLM3 support for OpenVINO export and fix position_ids double-append#1761
Closed
mlukasze wants to merge 1 commit into
Closed
[EXPERIMENT][WIP] Add SmolLM3 support for OpenVINO export and fix position_ids double-append#1761mlukasze wants to merge 1 commit into
mlukasze wants to merge 1 commit into
Conversation
…ition_ids double-append Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
product-grade PR has been merged here: #1715 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds OpenVINO export and inference support for SmolLM3 (HuggingFaceTB/SmolLM3-3B), and fixes a bug in
OVModelForCausalLMthat caused generation drift with recent transformers (>=5.x).Changes
1. Add SmolLM3 config (
optimum/exporters/openvino/model_configs.py)Added
SmolLM3OpenVINOConfigfor OpenVINO export support:TextDecoderWithPositionIdsOnnxConfig(position_ids support)MistralDummyPastKeyValuesGenerator(GQA: 4 KV heads vs 16 attention heads)OVDecoderModelPatcherfor SDPA patchingWithout this change, export fails with:
2. Fix position_ids double-append (
optimum/intel/openvino/modeling_decoder.py)_update_model_kwargs_for_generation()was double-appendingposition_idswith transformers 5.x, shifting token positions during autoregressive decoding and causing generation drift.Fixed by removing the extra append and relying on transformers
GenerationMixinupdate logic.3. Regression test (
tests/openvino/test_decoder.py)Added test to verify
OVModelForCausalLMdoes not mutate position_ids beyond the superclass result.4. Export coverage and docs
text-generation-with-pastcasetests/openvino/utils_tests.pyWWB Accuracy Results