FIX Remove duplicate VBLoRAConfig entry from peft.__all__#3279
Merged
githubnemo merged 4 commits intoJun 30, 2026
Merged
Conversation
githubnemo
reviewed
Jun 22, 2026
githubnemo
left a comment
githubnemo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR.
Indeed, this can be a problem. Instead of adding a unit test, let's add
"RUF068", # Duplicates in __all__
to pyproject.toml in tool.ruff.lint.extend-select since ruff is able to detect and fix this automatically.
Contributor
Author
There was a problem hiding this comment.
Done — removed tests/test_public_api.py and added RUF068 to extend-select in pyproject.toml. Confirmed locally that ruff check flags and auto-fixes the duplicate, and formatting/linting pass clean. Agreed this is much cleaner than the manual test — thanks for the steer.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
peft.__all__listed"VBLoRAConfig"twice. Duplicate entries in__all__silently confuse documentation tooling, IDE auto-import, and linters that rely on__all__to determine the public API surface. It's the only duplicate among the 138 entries.Changes
src/peft/__init__.py— remove the duplicate"VBLoRAConfig"entry.pyproject.toml— enable ruff'sRUF068(duplicate__all__entries) in[tool.ruff.lint]extend-select, so the same regression is caught and auto-fixed by the linter going forward. (Per @githubnemo's review suggestion — preferable to a hand-written test since ruff detects and fixes this automatically.)How to test