fix(tuners): bundle use of _cast_input_dtype across all PEFT methods#3280
Closed
Chessing234 wants to merge 1 commit into
Closed
fix(tuners): bundle use of _cast_input_dtype across all PEFT methods#3280Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
…oss all PEFT methods
This was referenced May 28, 2026
Member
|
@Chessing234 Why did you close all PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the same
_cast_input_dtypefix across all PEFT tuners to properly respect thedisable_lora_input_dtype_castingcontext manager. It replaces rawx.to()calls withself._cast_input_dtype(x, dtype)for all remaining tuners that were still using it (such as adamss, boft, c3a, fourierft, gralora, hra, ia3, lora, oft, poly, pvera, randlora, road, vblora, vera, and xlora). This bundles the fixes requested in #3177 and #3208 into a single PR.