Add UniLoraConfig to ALL_CONFIG_CLASSES test matrix#3383
Open
DaoyuanLi2816 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
UniLoraConfig(added in #3257) is missing fromALL_CONFIG_CLASSESintests/test_config.py, so it isn't covered by the config test matrix (to_dict/save_pretrained/from_pretrained/from_json_file, copy/pickle, etc.).This is the same kind of gap that #3365 addressed for
CPTConfig/RandLoraConfig(and the four others I added there).UniLoraConfiglanded afterwards without being registered. It's a publicPeftConfigsubclass with no mandatory init kwargs, so it's added as(UniLoraConfig, {}), consistent with the other entries.I re-checked the full matrix against every public
PeftConfig/PromptLearningConfigsubclass —UniLoraConfigis the only one currently missing.Before submitting