TST Skip failing Diffusers tests until v0.40.0#3394
Merged
BenjaminBossan merged 1 commit intoJul 6, 2026
Merged
Conversation
Due to a recent change in huggingface-hub, loading Diffusers pipelines in offline mode can fail. Since the PEFT caching mechanism works by setting offline mode, several PEFT tests are affected by this. There is a fix on the way in Diffusers, but there won't be a patch release: huggingface/diffusers#14118 Therefore, we skip these tests for now. Once Diffusers 0.40.0 releases, the tests will run again, but we can also remove the skipping logic completely.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
approved these changes
Jul 6, 2026
BenjaminBossan
added a commit
that referenced
this pull request
Jul 7, 2026
We have errors with the Windows CI when it tries to load the stable diffusion model. This is coming from the huggingface_hub 1.22 release. I could confirm that pinning to <1.22 resolved the issue. We already have a fix in #3394 due to this release but it didn't address the error above. In this PR, the stable diffusion pipeline is loaded as part of a class level fixture. There is a tricky issue that setting it on self doesn't work for class fixtures, which is probably why it wasn't implemented like this in the first place. The reason why this (presumably) solves the issue: According to the GLM analysis, this is a race condition that is aggravated on Windows due to how it handles symlinking. The old code is defined on the class level, which means that when the tests are set up, it runs immediately. Since we run with 3 xdist processes, all 3 fire at approximately the same time. This makes it more likely to trigger the race condition. Using a fixture, the SD pipeline is only loaded once the first test on the class is reached. Since many tests run before that, it is very unlikely that all xdist processes start loading at the same time. Therefore, the race condition is resolved for all practical purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a recent change in huggingface-hub, loading Diffusers pipelines in offline mode can fail. Since the PEFT caching mechanism works by setting offline mode, several PEFT tests are affected by this.
There is a fix on the way in Diffusers, but there won't be a patch release:
huggingface/diffusers#14118
Therefore, we skip these tests for now. Once Diffusers 0.40.0 releases, the tests will run again, but we can also remove the skipping logic completely.