spawn prometheus exporter#678
Conversation
|
Hey @augustas1, thanks for your contribution! Indeed this seems related to #729, but AFAIK the Prometheus port only applies for gRPC, as it requires to deploy the endpoint over HTTP; whereas on HTTP is not required as we can simply create the Could you elaborate on why do you think this is required or why? I guess it can be misleading to expose a Thanks in advance 🤗 |
|
Hey @alvarobartt, use case we had - we're using service mesh inside our cluster and mTLS for services. But in order to exclude metrics endpoint from mTLS it has to be on a separate port. We are starting to use OTLP as well now, are metrics being exported via OTLP as well? |
What does this PR do?
Spawns Prometheus exporter in the background. Currently metrics are not accessible via
PROMETHEUS_PORT(default9000), only via main port/metricsroute.Code addition matches the same what PrometheusBuilder::install does.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@alvarobartt @Narsil